After diving into suspending and resuming VyOS with VMware recently I found that the dhclient it runs via ether-resume.py is redundant as the netplug service already handles renewing dhcp on link changes quite well.
The netplug script does this much better than just plain dhclient <interface> as it specifies the correct flags to retain the existing dhcp lease.
I propose to remove the dhcp + dhclient part in ether-resume.py completely and let this automatically be handled by the netplug script /etc/netplug/linkup.d/dhclient (which is still Perl btw).
This would prevent dhclient from being run multiple times as well when the VM resumes.
Also ether-resume.py currently does not handle dhcpv6 addresses in the script.
Let me know if the proposed change sounds good and I will send a PR.