Page MenuHomeVyOS Platform
Create Task
Maniphest T3628

commit-archive source-address Interface Broken
Not ApplicablePublicBUG
Actions

Description

It looks like on 1.4, specifying an interface as a source is broken:

trae@cr01b-vyos# commit
Using source address lo
Archiving config...
  sftp://stor01z-rh8.int.trae32566.org:/int/cr01b-vyos Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 287, in upload
    upload_sftp(local_path, url.hostname, url.path, username, password, port, source, progressbar)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 166, in upload_sftp
    transfer_sftp('upload', *args, **kwargs)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 143, in transfer_sftp
    sock.bind((source, 0))
socket.gaierror: [Errno -5] No address associated with hostname
trae@cr01b-vyos# show commit-archive 
 location sftp://USER:PASSWORD@stor01z-rh8.int.trae32566.org:/int/cr01b-vyos
 source-address lo

Details

Version
1.4-rolling-202106151212
Is it a breaking change?
Unspecified (possibly destroys the router)

Related Objects
Search...

StatusSubtypeAssignedTask
 In progressFEATURE REQUESTNoneT3355 Remove all remaining legacy Vyatta code
 ResolvedFEATURE REQUESTerkinT3356 Script for remote file transfers
 Not ApplicableBUGerkinT3628 commit-archive source-address Interface Broken

Event Timeline

trae32566 created this task.Jun 16 2021, 7:01 AM
trae32566 added a parent task: T3356: Script for remote file transfers.
trae32566 renamed this task from commit-archive source-address interface Broken to commit-archive source-address Interface Broken.Jun 16 2021, 7:03 AM
erkin claimed this task.Jun 20 2021, 2:40 PM
erkin changed the task status from Open to In progress.Jun 20 2021, 3:48 PM
erkin triaged this task as Normal priority.
Restricted Repository Identity mentioned this in rVYOSONEX0de84e53c366: Merge pull request #893 from erkin/T3628.Jun 20 2021, 7:51 PM
erkin closed this task as Resolved.Jun 21 2021, 4:56 AM
pasik subscribed.Jun 21 2021, 6:48 AM
trae32566 reopened this task as Open.Jul 7 2021, 5:51 AM

This is still broken on the most recent rolling release:

trae@cr01a-vyos# commit
Using source address lo
Archiving config...
  sftp://stor01z-rh8.int.trae32566.org:/int/cr01a-vyos Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 315, in upload
    upload_sftp(local_path, url.hostname, url.path, username, password, port, source, progressbar)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 190, in upload_sftp
    transfer_sftp('upload', *args, **kwargs)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 162, in transfer_sftp
    sock.connect((hostname, port))
OSError: [Errno 22] Invalid argument
[edit protocols bgp]
erkin changed the task status from Open to In progress.Jul 7 2021, 9:03 AM

@trae32566 I can't replicate this. Can you post your config?

trae32566 added a comment.Jul 8 2021, 5:20 AM
trae@cr01a-vyos# show system config-management 
 commit-archive {
     location sftp://cr01a-vyos.int:<somePassword>@stor01z-rh8.int.trae32566.org:/int/cr01a-vyos
     source-address lo
 }
 commit-revisions 10000
erkin added a comment.Dec 2 2021, 2:30 PM

The way sockets are handled in the last version should've fixed this once and for all.

erkin closed this task as Resolved.Dec 16 2021, 2:07 PM
trae32566 added a comment.Dec 17 2021, 9:30 AM

Still broken:

trae@cr01b-vyos:~$ show conf com | grep arch
set service dhcp-server shared-network-name INT subnet 192.168.1.0/24 domain-search 'int.trae32566.org'
set service dhcp-server shared-network-name INT subnet 192.168.1.0/24 domain-search 'ipa.trae32566.org'
set service dhcp-server shared-network-name INT subnet 192.168.1.0/24 domain-search 'trae32566.org'
set system config-management commit-archive location 'sftp://USER:PASS@stor01z-rh8.int.trae32566.org:/int/cr01b-vyos'                                                                          
set system config-management commit-archive source-address 'lo'
set system domain-search domain 'int.trae32566.org'
set system domain-search domain 'ipa.trae32566.org'
set system domain-search domain 'trae32566.org'
trae@cr01b-vyos:~$ configure
[edit]
trae@cr01b-vyos# set system host-name temp
[edit]
trae@cr01b-vyos# commit
Using source address lo
Archiving config...
  sftp://stor01z-rh8.int.trae32566.org:/int/cr01b-vyos Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 312, in upload
    urlc(urlstring, *args, **kwargs).upload(local_path)
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 202, in upload
    with self._establish() as ssh, ssh.open_sftp() as sftp:
  File "/usr/lib/python3/dist-packages/vyos/remote.py", line 189, in _establish
    sock = socket.create_connection((self.hostname, self.port), socket.getdefaulttimeout(), self.source)
  File "/usr/lib/python3.9/socket.py", line 843, in create_connection
    raise err
  File "/usr/lib/python3.9/socket.py", line 830, in create_connection
    sock.bind(source_address)
socket.gaierror: [Errno -5] No address associated with hostname
[edit]

This is on 1.4-rolling-202112160318

trae32566 reopened this task as Open.Dec 17 2021, 9:31 AM
trae32566 added a comment.Dec 17 2021, 10:46 AM
This comment was removed by trae32566.
erkin closed this task as Not Applicable.Dec 22 2021, 4:52 AM

I opened a new issue for this: T4090.