Page MenuHomeVyOS Platform
Create Task
Maniphest T3532

Not possible to change ethertype after interface creation
Closed, ResolvedPublicBUG
Actions

Description

If you first configure a QinQ interface and then later try to change the ethertype to 802.1q the ethertype is not changed.

set interfaces ethernet eth0 vif-s 700 vif-c 20 address 10.0.0.1/24
commit

set interfaces ethernet eth0 vif-s 700 protocol 802.1q
commit

sudo ip -d link show dev eth0.700
13: eth0.700@eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000
    link/ether 00:0d:b9:5a:2e:54 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535
    vlan protocol 802.1ad id 700 <REORDER_HDR> addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535

If you configure 802.1q first the ethertype is set correct.

set interfaces ethernet eth0 vif-s 700 protocol '802.1q'
set interfaces ethernet eth0 vif-s 700 vif-c 20 address '10.0.0.1/24'
commit

sudo ip -d link show dev eth0.700
15: eth0.700@eth0: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state LOWERLAYERDOWN mode DEFAULT group default qlen 1000
    link/ether 00:0d:b9:5a:2e:54 brd ff:ff:ff:ff:ff:ff promiscuity 0 minmtu 0 maxmtu 65535
    vlan protocol 802.1Q id 700 <REORDER_HDR> addrgenmode none numtxqueues 1 numrxqueues 1 gso_max_size 65536 gso_max_segs 65535

Details

Version
1.4-rolling-202105051111
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

thastad created this task.May 10 2021, 9:48 AM
pasik subscribed.May 10 2021, 10:50 AM
Viacheslav triaged this task as Normal priority.May 12 2021, 6:26 PM
Viacheslav edited a custom field.
Viacheslav changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po claimed this task.May 13 2021, 9:24 AM
jack9603301 subscribed.May 13 2021, 11:36 AM

PR: https://github.com/vyos/vyos-1x/pull/838

c-po mentioned this in rVYOSONEXcd504035015d: vyos.ifconfig: T3532: re-create Q-in-Q interface on protocol change.May 15 2021, 3:07 PM
c-po mentioned this in rVYOSONEX7eedd045534c: smoketest: interfaces: add testcase for q-in-q protocol change.
c-po mentioned this in rVYOSONEXedcdea890b2e: vyos.ifconfig: T3532: re-create Q-in-Q interface on protocol change.May 15 2021, 3:10 PM
c-po closed this task as Resolved.May 15 2021, 3:11 PM
c-po added a project: VyOS 1.3 Equuleus.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.
c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.
Viacheslav subscribed.EditedMay 20 2021, 4:25 PM

https://github.com/vyos/vyos-1x/commit/edcdea890b2eeb03d24b06fdd8ac38133e631c05

Function get_interface_config itself not added. Needs to add it for 1.3.

vyos@r4-1.3:~$ show int
Traceback (most recent call last):
  File "/usr/libexec/vyos/op_mode/show_interfaces.py", line 26, in <module>
    from vyos.ifconfig import Section
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/__init__.py", line 18, in <module>
    from vyos.ifconfig.interface import Interface
  File "/usr/lib/python3/dist-packages/vyos/ifconfig/interface.py", line 39, in <module>
    from vyos.util import get_interface_config
ImportError: cannot import name 'get_interface_config' from 'vyos.util' (/usr/lib/python3/dist-packages/vyos/util.py)
vyos@r4-1.3:~$
Viacheslav added a comment.May 20 2021, 4:43 PM

PR https://github.com/vyos/vyos-1x/pull/849

Restricted Repository Identity mentioned this in rVYOSONEX8fdebbe140bd: vyos.util: T3532: Replace func get_interface_config.May 20 2021, 8:01 PM
SrividyaA set Issue type to Bug (incorrect behavior).Aug 31 2021, 3:06 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 7:12 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.