Page MenuHomeVyOS Platform
Create Task
Maniphest T3455

system users can not be added in "edit"
Closed, ResolvedPublicBUG
Actions

Description

vyos@vyos# edit system login
vyos@vyos# set user foo authentication plaintext-password bar
vyos@vyos# commit
Configuration path: [system login user foo authentication plaintext-password] is not valid

Delete failed
Configuration path: [system login user foo authentication encrypted-password $6$VDzi4CPNprXbQM4Z$jcuC1d5Gh8Xjr3be4K.GDND8aROjXmJHvD11aZj1LojruvwCpvY66PEcu4qoD6X1VW1GaSMh3.BthvSDJIsQU1] is not valid

Set failed

Runing the same command not from edit works

vyos@vyos# set system login user foo authentication plaintext-password bar
vyos@vyos# commit

Details

Difficulty level
Unknown (require assessment)
Version
1.3.0-rc1
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

c-po created this task.Apr 2 2021, 9:35 PM
c-po updated the task description. (Show Details)
c-po updated the task description. (Show Details)
c-po renamed this task from edit mode breaks adding system users to system users can not be added in "edit".Apr 2 2021, 9:41 PM
Viacheslav added a subscriber: Viacheslav.Apr 3 2021, 8:53 AM

It seems that "call" doesn't react to env.

'VYATTA_EDIT_LEVEL': '/system/login'

https://github.com/vyos/vyos-1x/blob/810f4700acc9816178dc9a7f5f555bbde71a141d/src/conf_mode/system-login.py#L161

Viacheslav added a comment.Apr 3 2021, 10:15 AM

We can do some workaround for that level,

lvl = env['VYATTA_EDIT_LEVEL']
if lvl != '/':
    lvl = lvl.replace(lvl, ' ')
    call(f"/opt/vyatta/sbin/my_delete {lvl} user '{user}' " \
         f"authentication plaintext-password", env=env)
    call(f"/opt/vyatta/sbin/my_set {lvl} user '{user}' " \
         f"authentication encrypted-password '{encrypted_password}'", env=env)
else:
    call(f"/opt/vyatta/sbin/my_delete system login user '{user}' " \
         f"authentication plaintext-password", env=env)
    call(f"/opt/vyatta/sbin/my_set system login user '{user}' " \
         f"authentication encrypted-password '{encrypted_password}'", env=env)

But how about other levels, we get the same error for example with "edit system login user foo"

pasik added a subscriber: pasik.Apr 3 2021, 1:38 PM
Viacheslav added a comment.Apr 13 2021, 4:09 PM

PR https://github.com/vyos/vyos-1x/pull/802

vyos@r4-roll# edit system login 
[edit system login]
vyos@r4-roll# set user foo authentication plaintext-password bar
[edit system login]
vyos@r4-roll# commit
[edit system login]
vyos@r4-roll# show user foo 
 authentication {
     encrypted-password $6$qpdouYBuwFjsVzBB$Zu3sf9yQgNRCJUtM2E5F955xKchpMkEnA61fVo3ZLfJ2Y.pwdFOuoKSUGWtiB/YXxJmYnCEQyhzvLw5GZdQLB1
 }
[edit system login]
vyos@r4-roll#
Viacheslav changed the task status from Open to Needs testing.Apr 13 2021, 5:10 PM
Viacheslav added a comment.Apr 27 2021, 4:13 PM

Works perfect in VyOS 1.4-rolling-202104260417

vyos@r6-roll:~$ conf
e[edit]
vyos@r6-roll# edit system login 
[edit system login]
vyos@r6-roll# set user foo authentication plaintext-password bar
[edit system login]
vyos@r6-roll# commit
[edit system login]
vyos@r6-roll# 
[edit system login]
vyos@r6-roll# show 
 user foo {
     authentication {
         encrypted-password $6$opwXqEjDESjL1QTL$tOC4oJfpVGMdUeHXNYU299JsXpR07jR9X1lBjKyG6AcHKQfvve1Zj/6cqqQ.L4kAuHMSBysXhcNa1y2UTA56M1
     }
 }
Viacheslav moved this task from Need Triage to Backport Candidates on the VyOS 1.4 Sagitta board.Apr 27 2021, 4:13 PM
Viacheslav closed this task as Resolved.Jun 7 2021, 11:12 PM
Viacheslav claimed this task.
c-po moved this task from Backport Candidates to Finished on the VyOS 1.4 Sagitta board.Jun 13 2021, 11:23 AM
SrividyaA set Issue type to Bug (incorrect behavior).Aug 31 2021, 5:31 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 6 2021, 11:43 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:16 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.