Page MenuHomeVyOS Platform
Create Task
Maniphest T3397

getty forces --keep-baud in 1.2.x
Confirmed, NormalPublicBUG
Actions

Description

After upgrading to 1.2.x, my IPMI serial consoles are broken because getty passes --keep-baud and the kernel command line does not start with the right bit rate.

In 1.1.8, the getty command was /sbin/getty -L ttyS1 115200 vt100. In 1.2.6, it is /sbin/agetty --keep-baud 115200 ttyS1 vt102. I verified that editing the systemd unit and removing --keep-baud makes getty work again.

It seems to me that if a user has manually configured a bit rate in set system console device blah speed, then --keep-baud should not be on the generated command line? It would also be nice if this console device would be configured in grub.cfg so that it got initialized correctly at boot time...

Details

Difficulty level
Easy (less than an hour)
Version
1.2.6-S1
Why the issue appeared?
Issues in third-party code
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

jbrown created this task.Mar 8 2021, 8:50 PM
jbrown added a comment.Mar 15 2021, 11:27 PM

This totally breaks remote console access for me on 1.2.6, FWIW, so I consider it a fairly serious bug.

dmbaturin claimed this task.May 29 2021, 8:06 AM
dmbaturin added a project: VyOS 1.2 Crux (VyOS 1.2.8).
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.9); removed VyOS 1.2 Crux (VyOS 1.2.8).Jul 19 2021, 8:51 PM
zsdc changed the task status from Open to Confirmed.Jan 26 2022, 8:28 PM
zsdc triaged this task as Normal priority.
zsdc added projects: VyOS 1.3 Equuleus ( 1.3.1), VyOS 1.4 Sagitta.
zsdc changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
zsdc changed Why the issue appeared? from Will be filled on close to Issues in third-party code.
zsdc changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
zsdc set Issue type to Bug (incorrect behavior).
zsdc added a subscriber: zsdc.Jan 26 2022, 8:33 PM

We confirmed the problem - some serial consoles continue to work well, some are not initialized properly with the --keep-baud option. For example, this can be reproduced in the SOS console in Equinix Metal.
Originally, the problem comes from a systemd service template.
Since it is not completely clear if the option is necessary in one case or another, it seems that the best solution would be to provide the ability to set/remove it from the CLI, so everyone may configure what works best for his hardware.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus ( 1.3.1).Aug 29 2022, 12:12 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:39 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:37 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.7); removed VyOS 1.3 Equuleus (1.3.6).Feb 10 2024, 9:17 AM