Page MenuHomeVyOS Platform
Create Task
Maniphest T3370

dhcp: Invalid domain name "private"
Closed, ResolvedPublicBUG
Actions

Description

vyos@vyos# set service dhcp-server shared-network-name LAN subnet 192.168.1.0/24 domain-name private
  Invalid domain name (RFC 1123 section 2).
  May only contain letters, numbers and .-_
  Value validation failed
  Set failed

The line is validated by https://github.com/vyos/vyos-1x/blob/ede8217b6345b58da85f68ca024b54e04fd6348c/src/validators/fqdn

We probably should adjust that regex to the same one we use on system domain-name which is [A-Za-z0-9][-.A-Za-z0-9]*

Details

Difficulty level
Easy (less than an hour)
Version
1.3.0-rc1
Why the issue appeared?
Implementation mistake
Is it a breaking change?
Stricter validation
Issue type
Bug (incorrect behavior)

Event Timeline

c-po created this task.Feb 28 2021, 8:44 AM
dmbaturin added a subscriber: dmbaturin.Feb 28 2021, 8:46 AM

I agree we should just check if it starts with a letter and doesn't include characters that an FQDN cannot have.

OR we should write a rigorous RFC-compliant validator, but for now we need to stop valid domains from failing, so I'm all for that regex change.

c-po changed the task status from Open to In progress.Feb 28 2021, 8:57 AM
c-po claimed this task.
c-po added a project: VyOS 1.4 Sagitta.
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Implementation mistake.
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Stricter validation.
c-po moved this task from Need Triage to In Progress on the VyOS 1.4 Sagitta board.
c-po moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
c-po added a comment.Feb 28 2021, 8:59 AM

Temporary workaround for the VyOS 1.3-rc1 users:

Remove the syntax:expression line from /opt/vyatta/share/vyatta-cfg/templates/service/dhcp-server/shared-network-name/node.tag/subnet/node.tag/domain-name/node.def

c-po closed this task as Resolved.Feb 28 2021, 9:02 AM
c-po triaged this task as Unbreak Now! priority.
pasik added a subscriber: pasik.Feb 28 2021, 11:06 AM
c-po moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.Mar 18 2021, 4:28 PM
c-po moved this task from In Progress to Finished on the VyOS 1.4 Sagitta board.May 24 2021, 7:37 PM
SrividyaA set Issue type to Bug (incorrect behavior).Aug 31 2021, 1:53 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:17 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.