Ethernet: "disable" flag is not honored after a reboot for VIF interfaces
Closed, WontfixPublicBUG
Actions

Assigned To

Authored By

	c-po
	Feb 23 2021, 6:44 PM

Description

When configuring an interface with the disable keyword and a saved config it is expected that the interface will stay admin down even after a reboot.

This is not the case, after a reboot the interface is admin up, besides the fact that the CLI tells us it is admin down.

To reproduce:

set interfaces ethernet eth2 vif 15 address 192.0.2.1/24
set interfaces ethernet eth2 vif 15 disable
commit
save

vyos@vyos:~$ show interfaces | match eth2.15
eth2.15          192.0.2.1/24                      A/D
vyos@vyos# run reboot now

After a reboot

vyos@vyos:~$ show interfaces | match eth2.15
eth2.15          192.0.2.1/24                      u/D

Reproduce on crux

set interfaces ethernet eth1 vif 20 disable
set interfaces ethernet eth1 disable
commit

delete interfaces ethernet eth1 disable
commit

This will automatically enable the sub interface

7: eth1.20@eth1: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc noqueue state UP group default qlen 1000
    link/ether 00:50:56:b3:09:07 brd ff:ff:ff:ff:ff:ff
    inet6 fe80::250:56ff:feb3:907/64 scope link
       valid_lft forever preferred_lft forever

Reproduce with iproute2

Using simple iproute2 commands:

ip link add link eth1 name eth1.20 type vlan id 20
ip link set dev eth1.20 down
ip link set dev eth1 down
ip link set dev eth1 up

98: eth1.20@eth1: <NO-CARRIER,BROADCAST,MULTICAST,UP> mtu 1500 qdisc noqueue state LOWERLAYERDOWN group default qlen 1000
    link/ether 00:50:56:bf:ef:aa brd ff:ff:ff:ff:ff:ff

Summary

The down state of an interface is not honored by iproute2 when the lower interface trnasitions from down -> up all subinterfaces (vlans) will be placed in admin-up state as well!

Details

Version: 1.3-beta-202102150443
Is it a breaking change?: Unspecified (possibly destroys the router)

Related Objects

Mentioned In: rVYOSONEXc3df52388bb0: smoketest: vif: T3349: derive test_vif_8021q_lower_up_down for bridge
T3375: Interface becomes up at boot even when disabled
rVYOSONEXbbfe367648be: vif: T3349: use fixed ordering when enabling parent and child interface
rVYOSONEX49bc3f1e3ff8: vif: T3349: use fixed ordering when enabling parent and child interface

Event Timeline

c-po created this task.Feb 23 2021, 6:44 PM

c-po renamed this task from Ethernet: "disable" flag is not honored after a reboot to Ethernet: "disable" flag is not honored after a reboot for VIF interfaces.Feb 23 2021, 6:46 PM

c-po changed the task status from Open to Confirmed.

c-po claimed this task.

c-po triaged this task as Urgent! priority.

c-po updated the task description. (Show Details)

c-po added a project: VyOS 1.4 Sagitta.

pasik subscribed.Feb 23 2021, 8:22 PM

c-po updated the task description. (Show Details)Feb 26 2021, 10:33 PM

c-po added a project: Restricted Project.

c-po updated the task description. (Show Details)

c-po updated the task description. (Show Details)Feb 26 2021, 10:36 PM

c-po edited projects, added VyOS 1.2 Crux (VyOS 1.2.7); removed Restricted Project.Feb 28 2021, 11:15 AM

c-po moved this task from Needs Triage to Backlog on the VyOS 1.2 Crux (VyOS 1.2.7) board.

c-po mentioned this in rVYOSONEX49bc3f1e3ff8: vif: T3349: use fixed ordering when enabling parent and child interface.Feb 28 2021, 5:10 PM

c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.Feb 28 2021, 5:10 PM

c-po mentioned this in rVYOSONEXbbfe367648be: vif: T3349: use fixed ordering when enabling parent and child interface.Mar 1 2021, 9:48 AM

Viacheslav mentioned this in T3375: Interface becomes up at boot even when disabled.Mar 1 2021, 5:12 PM

FileGo subscribed.Mar 1 2021, 5:36 PM

c-po mentioned this in rVYOSONEXc3df52388bb0: smoketest: vif: T3349: derive test_vif_8021q_lower_up_down for bridge.Mar 1 2021, 6:25 PM

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Mar 1 2021, 6:29 PM

c-po moved this task from Backlog to In Progress on the VyOS 1.2 Crux (VyOS 1.2.7) board.

Giving the nature of the nesting of node.def files and their execution pattern this can not be fixed in 1.2.

As calling delete interfaces ethernet eth1 disable will only execute the corresponding node.def file this will call ip link set dev eth1 up which will place all interfaces in admin-up state.

Marking this as "wontfix" in 1.2

c-po closed this task as Wontfix.Mar 1 2021, 6:47 PM

c-po moved this task from In Progress to Backlog on the VyOS 1.2 Crux (VyOS 1.2.7) board.

syncer moved this task from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.7) board.Jul 19 2021, 8:48 PM

dmbaturin removed a project: VyOS 1.3 Equuleus.Sep 10 2021, 2:38 PM