Page MenuHomeVyOS Platform
Create Task
Maniphest T3210

ISIS three-way-handshake
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

I think the command set protocols isis <name> interface <interface> three-way-handshake uses incorrectly. It does not do anything. Because it has already enabled by default.
The related interface mode command in FRR isis three-way-handshake is not displayed in config.

I think it would be better to make command set protocols isis <name> interface <interface> three-way-handshake-disable which will lead to disable three-way-handshake on given interface. The related interface mode command in FRR no isis three-way-handshake which is displayed in config and changes the default behavior.

Details

Version
-
Is it a breaking change?
Config syntax change (non-migratable)
Issue type
Feature (new functionality)

Related Objects

Event Timeline

craterman created this task.Jan 12 2021, 11:01 AM
Viacheslav subscribed.EditedJan 12 2021, 7:19 PM

@craterman It makes sense, thanks.
PR https://github.com/vyos/vyos-1x/pull/679

Restricted Repository Identity mentioned this in rVYOSONEX2f24ecbdfc86: Merge pull request #679 from sever-sever/T3210.Jan 12 2021, 10:33 PM
Restricted Repository Identity mentioned this in rVYOSONEX2cace1bdf16f: is-is: T3210: Fix three-way-handshake.Jan 12 2021, 10:33 PM
c-po subscribed.Jan 14 2021, 5:39 PM

backported to equuleus

c-po mentioned this in rVYOSONEX4787e3ccd898: is-is: T3210: Fix three-way-handshake.Jan 14 2021, 5:39 PM
c-po changed the task status from Open to Needs testing.Jan 14 2021, 5:40 PM
c-po assigned this task to Viacheslav.
Viacheslav closed this task as Resolved.Jan 15 2021, 2:08 PM

Fixed VyOS 1.4-rolling-202101150632

set protocols isis FOO interface eth1 no-three-way-handshake
set protocols isis FOO net '49.0001.1921.6800.1002.00'

Vtysh

!
interface eth1
 ip router isis FOO
 no isis three-way-handshake
!
router isis FOO
 net 49.0001.1921.6800.1002.00
!
pasik subscribed.Jan 15 2021, 3:24 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Mar 18 2021, 4:27 PM
c-po moved this task from Open to Finished on the VyOS 1.4 Sagitta board.May 24 2021, 7:41 PM
SrividyaA set Issue type to improvement.Aug 30 2021, 3:58 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:26 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.
dmbaturin set Issue type to Feature (new functionality).Nov 8 2024, 10:48 AM