Page MenuHomeVyOS Platform
Create Task
Maniphest T3173

Need 'nopmtudisc' option for tunnel interface
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Need 'nopmtudisc' option for tunnel interface. This is required for MPLS over gre or Ethernet over gre applications. This option is described in the iproute2 manuals (ip-tunnel).

Details

Difficulty level
Normal (likely a few hours)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Related Objects

Mentioned In
T915: MPLS Support

Event Timeline

daniil created this task.Jan 1 2021, 3:52 PM
daniil created this object in space S1 VyOS Public.
daniil mentioned this in T915: MPLS Support.
pasik added a subscriber: pasik.Jan 1 2021, 5:14 PM
Viacheslav added a subscriber: Viacheslav.Jan 4 2021, 12:53 PM

Proposed CLI

set interfaces tunnel tun0 parameters ip disable-pmtu-discovery

or

set interfaces tunnel tun0 parameters ip pmtu-discovery-disable
Cheeze_It added a subscriber: Cheeze_It.Jan 4 2021, 3:08 PM

I'd personally recommend "pmtu-discovery-disable", but either would be fine.

runar added a subscriber: runar.Jan 5 2021, 6:20 AM

As far as i know all our other "disable" commands starts wirh "disable-"

c-po added a subscriber: c-po.Jan 7 2021, 9:13 PM

@runar we also added no- in the 1.3 series, so I'd prefer: set interfaces tunnel tun0 parameters ip disable-pmtu-discovery or set interfaces tunnel tun0 parameters ip no-pmtu-discovery

Viacheslav added a comment.Jan 10 2021, 4:52 PM

PR https://github.com/vyos/vyos-1x/pull/676

It is difficult to do in this performance this option as "valueless" because all tunnel options defined in tunnel.py interfaces-tunnel.py "IP route" format "ip tunnel add ttl/tos/key/etc"
When an option has already been passed to the tunnel.py script, it checks its value anyway.
So I should use enable/disable style

set interfaces tunnel tun0 address '10.5.2.1/30'
set interfaces tunnel tun0 encapsulation 'gre'
set interfaces tunnel tun0 local-ip '192.168.122.15'
set interfaces tunnel tun0 multicast 'enable'
set interfaces tunnel tun0 parameters ip ttl '0'
set interfaces tunnel tun0 remote-ip '192.168.122.1'
set interfaces tunnel tun0 parameters ip pmtu-discovery 'disable'

Check

vyos@r5-roll# sudo ip -d tunnel show tun0
tun0: gre/ip remote 192.168.122.1 local 192.168.122.15 ttl inherit tos inherit nopmtudisc
[edit]
vyos@r5-roll#
c-po added a comment.Jan 15 2021, 6:37 PM

CLI command will be: set interfaces tunnel tun10 parameters ip no-pmtu-discovery, Also PMTU can not be changed in IPv6 sourced tunnels, a validation check has been added.

Should be backported to 1.3 equuleus branch after it's confirmed properly working.

c-po changed the task status from Open to Needs testing.Jan 15 2021, 6:37 PM
c-po claimed this task.
c-po triaged this task as Low priority.
c-po changed Difficulty level from Easy (less than an hour) to Normal (likely a few hours).
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.Jan 16 2021, 8:04 AM
c-po moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.
Viacheslav added a comment.Jan 20 2021, 11:04 AM

'nopmtudisc' option still not present

set interfaces tunnel tun0 address '10.0.0.1/30'
set interfaces tunnel tun0 encapsulation 'gre'
set interfaces tunnel tun0 local-ip '192.0.2.55'
set interfaces tunnel tun0 parameters ip no-pmtu-discovery
set interfaces tunnel tun0 remote-ip '192.0.2.254'

Check

vyos@r5-roll# sudo ip -d tunnel show tun0
tun0: gre/ip remote 192.0.2.254 local 192.0.2.55 ttl inherit
c-po closed this task as Resolved.Feb 8 2021, 4:51 PM
c-po reopened this task as Backport candidate.
c-po edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.2 Crux.
c-po moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
c-po closed this task as Resolved.Feb 27 2021, 11:58 PM
c-po removed a project: VyOS 1.3 Equuleus.
c-po added a project: VyOS 1.3 Equuleus.Jul 25 2021, 8:52 AM
SrividyaA set Issue type to Improvement (missing useful functionality).Aug 30 2021, 12:29 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:26 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.