Page MenuHomeVyOS Platform
Create Task
Maniphest T3170

Add a sanity check for empty node.def files
Closed, ResolvedPublic
Actions

Description

Empty node.def's are usually a sign that something went wrong with the generation process, or that the original XML file doesn't have proper help strings at least. We should not allow them—there should be at least a help string.

Details

Version
-
Is it a breaking change?
Perfectly compatible

Related Objects

Event Timeline

dmbaturin created this task.Dec 31 2020, 2:26 PM
pasik subscribed.Jan 1 2021, 5:15 PM
c-po mentioned this in rVYOSONEXd8c27642a375: static: route: arp: T3170: prevent empty node.def from beeing generated.Apr 1 2021, 12:34 PM
Restricted Repository Identity mentioned this in rVYOSONEXb01065a762e3: Merge pull request #672 from dmbaturin/check-for-empty-nodes.Apr 2 2021, 9:17 AM
dmbaturin mentioned this in rVYOSONEX5b22ebae3ef7: T3170: check if any generated node.def files are empty..Apr 2 2021, 9:17 AM
c-po mentioned this in rVYOSONEX0f04a5e47e02: Revert "static: route: arp: T3170: prevent empty node.def from beeing generated".Apr 2 2021, 10:58 AM
c-po mentioned this in rVYOSONEX78871cb6ca63: Makefile: fix logic to detect empty "node.def" files.
c-po mentioned this in rVYOSONEX99440fc005d7: Makefile: fix logic to detect empty "node.def" files.Apr 2 2021, 5:35 PM
c-po closed this task as Resolved.Apr 30 2021, 8:48 PM
c-po mentioned this in rVYOSONEX88676e526c8f: T3170: check if any generated node.def file is empty.Jun 8 2021, 6:17 AM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 6 2021, 11:44 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:16 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.