Page MenuHomeVyOS Platform

ethernet ring-buffer can be set with an invalid value
Closed, ResolvedPublicFEATURE REQUEST

Description

Configuring the IGB ring-buffer size on an APU4 board does not support values > 4096.

A value of 8192 can be set which throws an error, but the commit itself is accepted. We now have an inconsistent system.

ethtool -g eth3
Ring parameters for eth3:
Pre-set maximums:
RX:             4096
RX Mini:        0
RX Jumbo:       0
TX:             4096
Current hardware settings:
RX:             256
RX Mini:        0
RX Jumbo:       0
TX:             256
vyos@vyos# set interfaces ethernet eth2 ring-buffer rx 8192
[edit]
vyos@vyos# commit
[ interfaces ethernet eth2 ]
could not set "rx" ring-buffer for eth2

besides this error message the CLI tells us that the commit went through.

ethernet eth2 {
    ring-buffer {
        rx 8192
    }
}
vyos@vyos# sudo ethtool -g eth2
Ring parameters for eth2:
Pre-set maximums:
RX:             4096
RX Mini:        0
RX Jumbo:       0
TX:             4096
Current hardware settings:
RX:             4096
RX Mini:        0
RX Jumbo:       0
TX:             256

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Mentioned In
rVYOSONEXf5f58669cccb: vyos.ethtool: T3163: ring-buffer values should be stored as string
rVYOSONEXb0d4112bd607: vyos.ethtool: T3163: purify code to read and change flow-control settings
rVYOSONEX6c280b1ca52c: vyos.ethtool: T3163: ring-buffer values should be stored as string
rVYOSONEX0229645c8248: vyos.ethtool: T3163: purify code to read and change flow-control settings
rVYOSONEXde3c476ccb60: ethernet: T3163: only change ring-buffer settings if required
rVYOSONEX29082959e0ef: ethernet: T3163: only change ring-buffer settings if required
rVYOSONEX5cbb1f3e4adb: vyos.ethtool: T3163: purify code to read current speed and duplex settings
rVYOSONEX6f5fb5c503b5: vyos.ethtool: T3163: purify code to read current speed and duplex settings
rVYOSONEXa086dc2c429a: vyos.ethtool: T3163: use long option names when calling the ethtool binray
rVYOSONEX862e6e96bfc5: vyos.ethtool: T3163: use long option names when calling the ethtool binray
rVYOSONEX6f31b78d867f: vyos.ethtool: T3163: remove test and debug method get_rx_vlan_offload()
rVYOSONEXebf69a83bd1a: vyos.ethtool: T3163: add check_speed_duplex() method
rVYOSONEXf4c6697582dd: vyos.ethtool: T3163: prefix class internal data structures with _
rVYOSONEX1c9db8997094: vyos.ethtool: T3163: drop obsoleted is_fixed_lro() method
rVYOSONEX50364a4b7a9d: vyos.ethtool: T3163: remove test and debug method get_rx_vlan_offload()
rVYOSONEX147f655a69cd: vyos.ethtool: T3163: add check_speed_duplex() method
rVYOSONEX324aa9598c7d: vyos.ethtool: T3163: prefix class internal data structures with _
rVYOSONEXeac8915413ce: vyos.ethtool: T3163: drop obsoleted is_fixed_lro() method
rVYOSONEX4abf852917b5: vyos.ethtool: T3163: rename unused methods for offload validation
rVYOSONEXd22f97af23ab: vyos.ethtool: T3163: rename unused methods for offload validation
rVYOSONEX40fdf5c61901: ethernet: T3163: fix typos in vyos.ethtool comments
rVYOSONEX249c8ad37e5e: ethernet: T3163: not all NIC drivers support ring-buffer configuration
rVYOSONEXbddeae3755c8: ethernet: T3163: fix typos in vyos.ethtool comments
rVYOSONEX159899ed9ba5: ethernet: T3163: not all NIC drivers support ring-buffer configuration
rVYOSONEXd14d2f30ef59: ethernet: T3163: probe driver for maximum rx/tx ring-buffer size
rVYOSONEXcf1156a60e1d: ethernet: T3163: probe driver for maximum rx/tx ring-buffer size

Event Timeline

c-po assigned this task to Unknown Object (User).
c-po triaged this task as Normal priority.
c-po changed the task status from Open to In progress.Feb 21 2021, 4:37 PM
c-po claimed this task.
c-po edited a custom field.
c-po added a project: VyOS 1.4 Sagitta.
c-po added a subscriber: Unknown Object (User).
erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 11:43 AM