Page MenuHomeVyOS Platform
Create Task
Maniphest T3090

Move 'adjust-mss' firewall options to the interface section.
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Getting rid of "set firewall options" and move it
From:

set firewall options interface ethX adjust-mss xxxx
set firewall options interface ethX adjust-mss6 xxxx

To:

set interfaces ethernet ethX ip adjust-mss xxxx
set interfaces ethernet ethX ipv6 adjust-mss xxxx

It's will be more clear.

Details

Difficulty level
Unknown (require assessment)
Version
-
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Related Objects
Search...

Event Timeline

Viacheslav created this task.Nov 28 2020, 2:16 PM
pasik added a subscriber: pasik.Nov 29 2020, 10:40 AM
jack9603301 added a subscriber: jack9603301.Dec 6 2020, 5:18 PM
mpueschel added a subscriber: mpueschel.May 25 2021, 10:07 AM
dmbaturin edited projects, added VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus.Jul 29 2021, 8:50 AM
c-po moved this task from Need Triage to Backlog on the VyOS 1.4 Sagitta board.Aug 1 2021, 8:46 AM
c-po claimed this task.Aug 15 2021, 3:25 PM
c-po closed this task as Resolved.Aug 22 2021, 10:01 AM
c-po moved this task from Backlog to Finished on the VyOS 1.4 Sagitta board.Sep 19 2021, 7:05 AM
Unknown Object (User) added a subscriber: Unknown Object (User).Oct 8 2021, 12:23 PM

Perhaps the command should be changed a bit
MSS is a property of the TCP protocol, not IP:

set interfaces ethernet ethX tcp adjust-mss xxxx
set interfaces ethernet ethX tcpv6 adjust-mss xxxx

TCPv6 is also not a good name. Maybe like this:

set interfaces ethernet ethX adjust-mss xxxx
set interfaces ethernet ethX adjust-mss6 xxxx

c-po added a comment.Oct 9 2021, 5:02 PM

You are right @NikolayP but opening an entire subtree might be a bit of overkill.

c-po mentioned this in T2892: Remove command: "set firewall options interface <interface> disable".Nov 1 2021, 5:30 PM
Viacheslav mentioned this in T4863: need an option for route policy to apply to dynamic interfaces l2tp*/ipoe*/pppoe* (for TCP MSS setting).Feb 8 2023, 9:23 AM
c-po changed the status of subtask T5465: adjust-mss: config migration fails if applied to a VLAN or Q-in-Q interface from Open to In progress.Aug 11 2023, 7:21 PM
c-po closed subtask T5465: adjust-mss: config migration fails if applied to a VLAN or Q-in-Q interface as Resolved.Aug 11 2023, 7:24 PM