compare + TAB completion does not show proper username if user contains _
Not ApplicablePublicBUG
Actions

Assigned To

None

Authored By

	c-po
	Aug 14 2020, 5:55 AM

Description

The username I operate with is foo_admin but in compare completion helper it is displayed as foo admin

foo_admin@vyos# compare
Possible completions:
  <Enter>       Compare working & active configurations
  saved         Compare working & saved configurations
  <N>           Compare working with revision N
  <N> <M>       Compare revision N with M

  Revisions:
    0   2020-08-14 07:52:20 foo admin by cli

Details

Version: 1.2.5
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Bug (incorrect behavior)

Event Timeline

c-po created this task.Aug 14 2020, 5:55 AM

pasik subscribed.Aug 14 2020, 6:17 PM

It looks like this problem is around here
https://github.com/vyos/vyatta-cfg/blob/current/etc/bash_completion.d/vyatta-cfg#L280-L290

called show-commit-log-brief

foo_bar@r4-roll# ${vyatta_sbindir}/vyatta-config-mgmt.pl --action=show-commit-log-brief
2020-09-26_15:48:28_foo_bar_by_cli 2020-09-26_15:48:02_foo_bar_by_cli 2020-09-26_15:46:53_vyos_by_cli 2020-09-26_15:28:30_vyos_by_other 2020-09-26_15:06:34_vyos_by_cli 2020-09-26_15:05:52_vyos_by_cli 2020-09-26_14:59:10_root_by_vyos-boot-config-loader 2020-09-26_14:58:29_vyos_by_cli 2020-09-26_14:58:18_vyos_by_cli 2020-09-26_14:57:53_vyos_by_cli 2020-09-26_14:57:50_vyos_by_cli 2020-09-26_14:55:11_vyos_by_cli 2020-09-26_14:35:54_root_by_vyos-boot-config-loader 2020-09-26_14:03:58_vyos_by_cli 2020-09-26_13:48:14_vyos_by_cli 2020-09-26_13:47:34_vyos_by_cli 2020-09-26_13:47:16_root_by_vyos-boot-config-loader 2020-09-26_13:46:26_vyos_by_cli 2020-09-26_13:46:10_vyos_by_cli 2020-09-26_13:44:52_vyos_by_cli 2020-09-26_13:15:12_vyos_by_cli 2020-09-26_12:12:06_vyos_by_cli 2020-09-26_12:11:46_vyos_by_cli 2020-09-26_12:11:24_root_by_vyos-boot-config-loader 2020-09-26_11:20:14_vyos_by_cli 2020-09-26_11:19:45_vyos_by_cli 2020-09-26_11:19:38_root_by_vyos-boot-config-loader 2020-09-26_11:18:43_vyos_by_cli 2020-09-26_10:33:29_root_by_vyos-boot-config-loader 2020-09-26_10:26:03_root_by_vyos-boot-config-loader 2020-09-24_09:23:29_vyos_by_cli 2020-09-24_09:23:24_root_by_vyos-boot-config-loader 2020-09-24_09:23:24_root_by_init [edit]
foo_bar@r4-roll#

dmbaturin edited projects, added test, VyOS 1.2 Crux (VyOS 1.2.9); removed VyOS 1.2 Crux.Jul 29 2021, 12:53 PM

erkin set Issue type to Bug (incorrect behavior).Aug 29 2021, 1:28 PM

erkin removed a subscriber: Global Notifications.

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1); removed test, VyOS 1.3 Equuleus.Sep 5 2021, 7:06 AM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus (1.3.0-epa1).Nov 1 2021, 10:09 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:05 AM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:40 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:29 PM

syncer edited projects, added VyOS 1.3 Equuleus (1.3.6); removed VyOS 1.3 Equuleus (1.3.5).Dec 17 2023, 11:37 PM