Page MenuHomeVyOS Platform
Create Task
Maniphest T2764

Increase maximum number of NAT rules
Closed, ResolvedPublicENHANCEMENT
Actions

Description

The current maximum of 9999 can be very limiting when having a custom numbering system (I use a 2-digit prefix that identifies all rules for a single destination IP and a 2-digit suffix for the rule number for that IP). I'm running into a situation where I need to configure more than 100 sub-rules for a single destination IP, this means I'd need to break my numbering system.

An easy fix would be to increase the maximum to 99999 or even 999999.

Details

Difficulty level
Easy (less than an hour)
Version
-
Why the issue appeared?
Design mistake
Is it a breaking change?
Perfectly compatible
Issue type
Improvement (missing useful functionality)

Related Objects

Mentioned In
1.3.3
1.3.1

Event Timeline

jjakob triaged this task as Normal priority.Aug 6 2020, 11:35 AM
jjakob created this task.
jjakob created this object in space S1 VyOS Public.
c-po added a subscriber: c-po.Aug 6 2020, 1:16 PM

This will be a oneliner in the new XML implementation. Just send PR

jack9603301 added a subscriber: jack9603301.Aug 6 2020, 1:24 PM
jjakob changed the task status from Open to In progress.Aug 6 2020, 3:37 PM
jjakob claimed this task.
jjakob moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
jjakob changed the subtype of this task from "Task" to "Enhancement".
pasik added a subscriber: pasik.Aug 7 2020, 3:42 PM
erkin set Issue type to Improvement (missing useful functionality).Aug 29 2021, 1:33 PM
erkin removed a subscriber: Active contributors.
syncer closed this task as Resolved.Oct 17 2021, 12:45 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1), VyOS 1.4 Sagitta; removed VyOS 1.3 Equuleus.
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0-epa1) board.
syncer moved this task from Need Triage to Finished on the VyOS 1.4 Sagitta board.
Unknown Object (User) reopened this task as Confirmed.Dec 25 2021, 6:07 AM
Unknown Object (User) added a subscriber: Unknown Object (User).

In 1.3.0 the limitation remains

c-po added a comment.Dec 25 2021, 9:31 AM

This happened because the rule numbers only got increased in the XML implementation but not in the old Perl backend. This has been fixed.

c-po added a comment.Dec 25 2021, 9:31 AM

https://github.com/vyos/vyatta-nat/commit/01b9a8598dabd391cc42da4c66d7a8067846b12b

c-po edited projects, added VyOS 1.3 Equuleus ( 1.3.1); removed VyOS 1.3 Equuleus (1.3.0-epa1).Dec 25 2021, 9:31 AM
c-po changed Difficulty level from Unknown (require assessment) to Easy (less than an hour).
c-po changed Why the issue appeared? from Will be filled on close to Design mistake.
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus ( 1.3.1) board.
Viacheslav closed this task as Resolved.Dec 27 2021, 4:20 PM
dmbaturin mentioned this in 1.3.1.Jun 11 2022, 8:40 AM
dmbaturin mentioned this in 1.3.3.Sep 22 2022, 10:56 AM