Page MenuHomeVyOS Platform
Create Task
Maniphest T2722

get_config_dict() and key_mangling=('-', '_') will alter CLI data for tagNodes
Closed, ResolvedPublicBUG
Actions

Description

When using key_mangling=('-', '_') the processor in the background will alter tagnodes and replace any - by _ which will cause faulty behavior as the data becomes invalid!

cpo@LR1.wue3# show system ntp
 server 172.16.100.10 {
 }
 server 172.16.100.20 {
 }
 server 172.16.110.30 {
 }
+server foo-bar.vyos.net {
+    prefer
+}
>>> from vyos.config import Config
>>> conf = Config()
>>> conf.get_config_dict(['system','ntp'], key_mangling=('-', '_'))
{'ntp': {'server': {'172.16.100.10': {}, '172.16.100.20': {}, '172.16.110.30': {}, 'foo_bar.vyos.net': {'prefer': {}}}}}
>>> conf.get_config_dict(['system','ntp'])
{'ntp': {'server': {'172.16.100.10': {}, '172.16.100.20': {}, '172.16.110.30': {}, 'foo-bar.vyos.net': {'prefer': {}}}}}

Workaround: https://github.com/vyos/vyos-1x/pull/511/files

Details

Version
1.3-rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Event Timeline

c-po created this task.Jul 21 2020, 2:10 PM
c-po assigned this task to dmbaturin.
c-po triaged this task as Urgent! priority.
Viacheslav subscribed.Jul 21 2020, 2:17 PM
jjakob subscribed.Jul 21 2020, 2:35 PM

I assume this will break 'system static-host-mapping host-name' and other places where tagnodes are used to carry string values as well

c-po added a comment.Jul 21 2020, 3:42 PM

It will break everything when in use ;)

Viacheslav closed this task as Resolved.Jun 24 2021, 8:32 PM

Already fixed with "no_tag_node_value_mangle=True"
https://github.com/vyos/vyos-1x/blob/705eddbc7a2caf09c37ecafb27418a764217975a/python/vyos/config.py#L218

erkin set Issue type to Internal change (not visible to end users).Aug 29 2021, 1:46 PM
erkin removed a subscriber: Global Notifications.
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 6 2021, 12:21 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:16 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.