Page MenuHomeVyOS Platform
Create Task
Maniphest T2555

XML op-mode generation scripts silently discard XML nodes
Closed, ResolvedPublicBUG
Actions

Description

Consider those two XML definitions:

both "generate" the file /opt/vyatta/share/vyatta-op/templates/show/protocols/node.def bot it is not populated with the help string from show-protocols-bfd.xml but rather is a simply, empty placeholder to entertain the vyatta-cfg backend.

I expect that on such a "conflict" two XML files generate the same node, the one which has populated the help string wins. Right now the only way to solve this is to copy the same <help> node to every file which is in the path of this node generation (bad).

Details

Version
1.3-rolling-202006060117
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)

Related Objects
Search...

Event Timeline

c-po created this task.Jun 6 2020, 2:06 PM
c-po assigned this task to dmbaturin.
Viacheslav subscribed.Jun 7 2020, 8:00 AM
c-po added a comment.Jun 7 2020, 9:27 AM

Idea: do not generate empty node.def file if there is no <properties> statement.

c-po moved this task from Need Triage to Backlog on the VyOS 1.3 Equuleus board.Dec 26 2020, 3:52 PM
dmbaturin mentioned this in T3165: Split node.def generation process into "generic" and "specific" stages.Dec 30 2020, 1:43 PM
c-po added a parent task: T3165: Split node.def generation process into "generic" and "specific" stages.Dec 30 2020, 2:02 PM
c-po closed this task as Resolved.Aug 23 2021, 7:52 AM
erkin set Issue type to Internal change (not visible to end users).Aug 30 2021, 5:44 AM
erkin removed a subscriber: Global Notifications.
c-po mentioned this in rVYOSONEX7623e37c918c: scripts: op-mode: T3807: bugfix node.def generator.Sep 7 2021, 9:42 AM
c-po mentioned this in rVYOSONEXadca504a2c5c: scripts: op-mode: T3807: bugfix node.def generator.Sep 7 2021, 9:52 AM
c-po moved this task from Backlog to 1.3.0-epa1 on the VyOS 1.3 Equuleus board.Sep 19 2021, 10:54 AM
c-po edited projects, added VyOS 1.3 Equuleus (1.3.0-epa1); removed VyOS 1.3 Equuleus.