Page MenuHomeVyOS Platform
Create Task
Maniphest T2468

Passwords with special characters fail in commit-archive
Open, Requires assessmentPublicBUG
Actions

Description

Passwords with special characters used in commit-archive fail:

# VyOS
vyos@cr01b-vyos# set interfaces dummy dum0 description "temporary description to force a commit proving it works before without special char"
[edit]
vyos@cr01b-vyos# commit
Using source address fd52:d62e:8011:6e:192:168:15:4
Archiving config...
  sftp://stor01z-cs.int.trae32566.org/cr01b-vyos  OK
[edit]
vyos@cr01b-vyos# delete system config-management commit-archive location 
[edit]
vyos@cr01b-vyos# set system config-management commit-archive location "sftp://cr01b:$T3$TP@$$W0^%@stor01z-cs.int.trae32566.org/cr01b-vyos"
[edit]
vyos@cr01b-vyos# commit
Using source address fd52:d62e:8011:6e:192:168:15:4
Archiving config...
  sftp://stor01z-cs.int.trae32566.org/cr01b-vyos curl: (6) Could not resolve host: 18274W0^%@stor01z-cs.int.trae32566.org
 Failed!
[edit]

Details

Difficulty level
Unknown (require assessment)
Version
1.3-rolling-202005150117
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

trae32566 created this task.May 16 2020, 8:05 AM
pasik added a subscriber: pasik.May 16 2020, 8:11 AM
jjakob added a subscriber: jjakob.May 16 2020, 8:21 AM

Passing passwords via command line arguments is very bad practice. Curl has a -u option, if passed just the user it prompts for the password on stdin. This can simply be passed via shell redirection.

jjakob mentioned this in T2552: [BUG] commit-archive domain recognition error.Jun 5 2020, 1:17 PM
jjakob merged a task: T2552: [BUG] commit-archive domain recognition error.
jjakob added a subscriber: ccieliu.
erkin renamed this task from Passwords with Special Characters in Commit Archive Fai to Passwords with special characters fail in commit-archive.Aug 30 2021, 6:11 AM
erkin set Issue type to Bug (incorrect behavior).
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Nov 6 2021, 11:24 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.3); removed VyOS 1.3 Equuleus (1.3.0).Aug 29 2022, 7:05 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.4); removed VyOS 1.3 Equuleus (1.3.3).Jul 12 2023, 9:41 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.5); removed VyOS 1.3 Equuleus (1.3.4).Aug 25 2023, 9:30 PM