Page MenuHomeVyOS Platform
Create Task
Maniphest T2436

equuleus: Testing: vyos-1x: syntax checking Python scripts in PR
Closed, ResolvedPublic
Actions

Description

In the past there have been quite a few tickets regarding python syntax errors on scripts rewritten to python.
To make a quickfix on some of these faults we could make a Jenkins step that executes: python3 -m compileall -q . to do a offline compile of the python files.

as for writing this tasks we have these faults in the repository:

*** Error compiling './src/conf_mode/interfaces-openvpn.py'...
Sorry: IndentationError: unindent does not match any outer indentation level (interfaces-openvpn.py, line 635)
*** Error compiling './src/conf_mode/interfaces-pseudo-ethernet.py'...
  File "./src/conf_mode/interfaces-pseudo-ethernet.py", line 130
    or peth['ipv6_autoconf'] ) ):
                                ^
SyntaxError: invalid syntax

*** Error compiling './src/conf_mode/interfaces-vxlan.py'...
  File "./src/conf_mode/interfaces-vxlan.py", line 172
    return None
    ^
SyntaxError: invalid syntax

Details

Version
-
Is it a breaking change?
Behavior change
Issue type
Internal change (not visible to end users)

Related Objects

Event Timeline

runar created this task.May 8 2020, 7:51 AM
runar created this object in space S1 VyOS Public.
jjakob subscribed.May 8 2020, 8:18 AM

Wouldn't it be better to add it to the vyos-1x Makefile so we could test it ourselves, before committing, making a PR, it being merged, and only then figuring out it's a problem?

jjakob added a comment.EditedMay 8 2020, 8:19 AM

The fix for the error for openvpn is already waiting in PR since yesterday, fix for pseudo-ethernet and vxlan will be ready right now.

pasik subscribed.May 8 2020, 9:33 AM
thomas-mangin subscribed.May 8 2020, 9:54 AM

I would also suggest doing the same using github actions so that on push to your local repository to get a warning from github.

thomas-mangin added a comment.May 8 2020, 10:22 AM

It seems that github has special rules for the .github file and that no PR can be done for it:
https://github.com/thomas-mangin/vyos-1x/blob/T2436/.github/workflows/pythonapp.yml

Restricted Repository Identity mentioned this in rVYOSONEX2c69daf94cbe: Merge pull request #401 from runborg/T2436.May 8 2020, 4:53 PM
jjakob added a comment.May 30 2020, 1:15 PM

This does not compile python scripts without a .py extension (there are several in src/services, src/utils that have #!/usr/bin/env python3)

thomas-mangin added a comment.May 30 2020, 1:49 PM

Many scripts also so do implement if name == “main”

dmbaturin closed this task as Resolved.May 29 2021, 7:40 AM
dmbaturin added a project: VyOS 1.3 Equuleus.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Behavior change.
erkin renamed this task from equuleus: Testing: vyos-1x: syntax checking python scripts in PR to equuleus: Testing: vyos-1x: syntax checking Python scripts in PR.Aug 30 2021, 6:18 AM
erkin set Issue type to Internal change (not visible to end users).
erkin removed a subscriber: Global Notifications.
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Nov 6 2021, 11:43 AM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 12:16 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.