Page MenuHomeVyOS Platform
Create Task
Maniphest T2278

build-vmware-image script has unmet dependencies (vyos/vyos-build PR#100)
Closed, ResolvedPublic
Actions

Description

The scripts/build-vmware-image script in the vyos/build-vyos repository has dependency on 3 binaries which do not appear in a container built according to the instructions.

This problem does not appear (the dependency appears to be met?) when fetching the build container (docker pull vyos/vyos-build:crux), but does appear when building the container (docker build -t vyos/vyos-build:latest)

The missing binaries are:

  • udevadm
  • kpartx
  • parted

The build-GCE-image script currently handles this problem (including two of the same packages) by installing the required packages as its first action.

I'll be following up this Task with a PR that follows that pattern.

edit: PR#100

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

chrismarget created this task.Apr 12 2020, 2:09 PM
chrismarget triaged this task as Normal priority.
chrismarget created this object in space S1 VyOS Public.
chrismarget renamed this task from build-vmware-image script has unmet dependencies to build-vmware-image script has unmet dependencies (vyos/vyos-build PR#100).Apr 12 2020, 2:16 PM
chrismarget updated the task description. (Show Details)
jestabro claimed this task.Apr 12 2020, 6:51 PM
chrismarget added a comment.Apr 12 2020, 8:30 PM

c-po closed PR#100 based on intent to restore (I didn't realize they'd been removed) those packages via the dockerfile.

I guess this task should close now too?

jestabro added a comment.Apr 12 2020, 8:40 PM

@chrismarget I'll commit the changes shortly, and close the task; thanks!

jestabro closed this task as Resolved.Apr 12 2020, 9:04 PM
chrismarget added a comment.Apr 12 2020, 9:48 PM

Thanks very much, @jestabro !