After re-writing list_interfaces.py to use Interfaces() pseudo-ethernet is missing
Closed, ResolvedPublicBUG
Actions

Assigned To

Authored By

	c-po
	Apr 7 2020, 7:50 PM

Description

Pseudo-Ethernet/MACVLAN interfaces should be listed on the list_interfaces.py --bridgable completion helper

Interface can be bridged, thus it should show up on the completion helper:

cpo@LR1.wue3# run show bridge
bridge name     bridge id               STP enabled     interfaces
br0             8000.0af4308d4071       no              l2tpeth10
                                                        peth0

Details

Version: 1.3-rolling-202004070927
Is it a breaking change?: Unspecified (possibly destroys the router)
Issue type: Bug (incorrect behavior)

Revisions and Commits

rVYOSONEX vyos-1x
	rVYOSONEX8bc128475685 completion: T2238: use interface data

Related Objects

Mentioned In: rVYOSONEX40ca59935073: completion: T2238: add license
rVYOSONEX11e809843856: Merge pull request #9 from thomas-mangin/T2238
rVYOSONEX73a9ff255de4: interfaces: T2238: update code to match new API
T2171: Unify creation and manipulation of interfaces
rVYOSONEX7ae606605e2f: Merge pull request #331 from thomas-mangin/T2223-register

Event Timeline

c-po created this task.Apr 7 2020, 7:50 PM

c-po assigned this task to thomas-mangin.

c-po triaged this task as Normal priority.

c-po updated the task description. (Show Details)

Hi @cpo,

Yes, it is missing, nothing to do with me but the fact the code does not yet find what is what from the interface data as we discussed.
https://github.com/vyos/vyos-1x/commit/bbea850ea5f8ff0402cd276ab63963ece7e0c763#diff-667867449bff9faf1ac285125ceada77

It will auto-magically get fixed when I finish the migration of show interfaces to python and update the file as the work is related and both will be done at the same time.
Hopefully within the week-end.

pasik subscribed.Apr 11 2020, 9:31 AM

https://github.com/vyos/vyos-1x/pull/331

Restricted Repository Identity mentioned this in rVYOSONEX7ae606605e2f: Merge pull request #331 from thomas-mangin/T2223-register.Apr 11 2020, 6:36 PM

thomas-mangin closed this task as Resolved.Apr 11 2020, 7:47 PM

thomas-mangin added a comment.Apr 11 2020, 9:50 PM

This comment was removed by thomas-mangin.

thomas-mangin added a commit: rVYOSONEX8bc128475685: completion: T2238: use interface data.Apr 11 2020, 9:52 PM

thomas-mangin mentioned this in T2171: Unify creation and manipulation of interfaces.Apr 11 2020, 10:30 PM

c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:24 PM

thomas-mangin mentioned this in rVYOSONEX73a9ff255de4: interfaces: T2238: update code to match new API.Aug 27 2020, 7:14 PM

Restricted Repository Identity mentioned this in rVYOSONEX11e809843856: Merge pull request #9 from thomas-mangin/T2238.Aug 27 2020, 7:14 PM

c-po mentioned this in rVYOSONEX40ca59935073: completion: T2238: add license.Sep 15 2020, 4:56 PM