Page MenuHomeVyOS Platform
Create Task
Maniphest T2212

vyos-1x: WiFi card antenna count not set accordingly
Closed, ResolvedPublicBUG
Actions

Description

Setting the antenna count for recent WiFi adapters requires to set multiple flags.
https://w1.fi/cgit/hostap/plain/hostapd/hostapd.conf

# vht_capab: VHT capabilities (list of flags)
# [...]
# Compressed Steering Number of Beamformer Antennas Supported:
# [BF-ANTENNA-2] [BF-ANTENNA-3] [BF-ANTENNA-4]
#   Beamformee's capability indicating the maximum number of beamformer
#   antennas the beamformee can support when sending compressed beamforming
#   feedback
# If SU beamformer capable, set to maximum value minus 1
# else reserved (default)
#
# Number of Sounding Dimensions:
# [SOUNDING-DIMENSION-2] [SOUNDING-DIMENSION-3] [SOUNDING-DIMENSION-4]
# Beamformer's capability indicating the maximum value of the NUM_STS parameter
# in the TXVECTOR of a VHT NDP
# If SU beamformer capable, set to maximum value minus 1
# else reserved (default)

This does not work in VyOS 1.3.

This worked in VyOS 1.2 (self-built at 201808072059).

Details

Difficulty level
Unknown (require assessment)
Version
vyos-1x commit id: 551e41895953bb291fc10bdb9ba2a07e83310070
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

alainlamar created this task.Apr 3 2020, 10:13 PM
alainlamar added a comment.Apr 4 2020, 11:56 AM

Here is the logic from my old wireless-hostapd.pl file:

my $vht_antenna_count = $config->returnValue("antenna-count");
if (defined($vht_antenna_count)) {
    if ($flag_vht_subeamformer > 0) {
        if ($vht_antenna_count > 1) {
            my $vht_ac_subf = $vht_antenna_count - 1;
            $vht_capab .= "[BF-ANTENNA-" . $vht_ac_subf . "][SOUNDING-DIMENSION-" . $vht_ac_subf . "]";
        }
        else {
            die "$level capabilities vht antenna-count : You cannot use beam forming with just one antenna!\n";
        }
    }
    else {
        $vht_capab .= "[BF-ANTENNA-" . $vht_antenna_count . "][SOUNDING-DIMENSION-" . $vht_antenna_count . "]";
    }
}
pasik added a subscriber: pasik.Apr 4 2020, 1:46 PM
alainlamar added a comment.Apr 5 2020, 10:03 AM

Pull request: https://github.com/vyos/vyos-1x/pull/305

alainlamar claimed this task.Apr 5 2020, 10:03 AM
alainlamar closed this task as Resolved.Apr 5 2020, 6:36 PM
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:25 PM
erkin set Issue type to Bug (incorrect behavior).Aug 30 2021, 7:43 AM
erkin removed a subscriber: Active contributors.
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:01 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.