Maniphest T2099

current rolling does not accept an empty pre-/post-login banner
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	afics
	Mar 4 2020, 8:01 PM

Tags

None

Referenced Files

None

Subscribers

Global Notifications

Description

vyos@vyos# show system login banner
>post-login ""
vyos@vyos# commit
[ system login banner ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/system-login-banner.py", line 85, in <module>
    c = get_config()
  File "/usr/libexec/vyos/conf_mode/system-login-banner.py", line 52, in get_config
    tmp = tmp.replace('\\n','\n')
AttributeError: 'NoneType' object has no attribute 'replace'

Details

Version: 1.3-rolling-202003031741
Is it a breaking change?: Unspecified (possibly destroys the router)

Related Objects

Mentioned In: T1928: Is the 'Welcome to VyOS' message when using SSH an information leak?
T2135: Login banner missing spacing now
rVYOSONEX28ff7570f117: banner: T2099: accept empty pre-/post-login banner
rVYOSONEX10ef1bb6c4a8: Merge branch 't31-vrf' of github.com:c-po/vyos-1x into current
rVYOSONEX94527843ecbf: templates: T2099: make op-mode path completion helper working

Event Timeline

afics created this task.Mar 4 2020, 8:01 PM

afics created this object in space S1 VyOS Public.

c-po changed the task status from Open to In progress.Mar 4 2020, 8:34 PM

c-po claimed this task.

c-po mentioned this in rVYOSONEX94527843ecbf: templates: T2099: make op-mode path completion helper working.Mar 4 2020, 9:05 PM

c-po mentioned this in rVYOSONEX10ef1bb6c4a8: Merge branch 't31-vrf' of github.com:c-po/vyos-1x into current.

c-po mentioned this in rVYOSONEX28ff7570f117: banner: T2099: accept empty pre-/post-login banner.Mar 4 2020, 9:13 PM

c-po closed this task as Resolved.Mar 4 2020, 9:13 PM

c-po triaged this task as Normal priority.

pasik subscribed.Mar 5 2020, 5:14 PM

kroy mentioned this in T2135: Login banner missing spacing now.Mar 17 2020, 9:40 PM

njh subscribed.May 24 2020, 10:07 AM

njh mentioned this in T1928: Is the 'Welcome to VyOS' message when using SSH an information leak?.May 24 2020, 10:10 AM