Page MenuHomeVyOS Platform
Create Task
Maniphest T1907

Traceback on a non-existent interface.
Closed, ResolvedPublicBUG
Actions

Description

If the network interface is not presented in the system, then too large code Traceback.
To reproduce.

vyos@1.3-netfl# set interfaces ethernet eth3 description test
[edit]
vyos@1.3-netfl# commit
[ interfaces ethernet eth3 ]
Traceback (most recent call last):
  File "/usr/libexec/vyos/conf_mode/interfaces-ethernet.py", line 449, in <module>
    apply(c)
  File "/usr/libexec/vyos/conf_mode/interfaces-ethernet.py", line 315, in apply
    e = EthernetIf(eth['intf'])
  File "/usr/lib/python3/dist-packages/vyos/ifconfig.py", line 1051, in __init__
    super().__init__(ifname)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig.py", line 941, in __init__
    super().__init__(ifname, type)
  File "/usr/lib/python3/dist-packages/vyos/ifconfig.py", line 88, in __init__
    raise Exception('interface "{}" not found'.format(self._ifname))
Exception: interface "eth3" not found

[[interfaces ethernet eth3]] failed
Commit failed
[edit]
vyos@1.3-netfl#

It will be enough:

interface "eth3" not found

Details

Version
VyOS 1.3-rolling-201912261106
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

Viacheslav created this task.Dec 26 2019, 8:37 PM
pasik subscribed.Dec 27 2019, 9:55 AM
Viacheslav closed this task as Resolved.Apr 21 2020, 5:42 PM
Viacheslav claimed this task.

Fixed in latest rolling

sever@r11-ansible# set interfaces ethernet eth3 description test
[edit]
sever@r11-ansible# commit
[ interfaces ethernet eth3 ]
Interface ethernet eth3 does not exist

[[interfaces ethernet eth3]] failed
Commit failed
[edit]
sever@r11-ansible# 


VyOS 1.3-rolling-202004210117
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.May 21 2020, 5:25 PM
erkin set Issue type to Bug (incorrect behavior).Aug 31 2021, 6:01 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:01 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.