This:
# set high-availability vrrp group VLAN3 priority 50;
Results in :
group VLAN3 {
interface eth0.3
> priority "50;"
virtual-address 10.3.1.1/24
vrid 3
}vs
group VLAN3 {
interface eth0.3
priority 50
virtual-address 10.3.1.1/24
vrid 3
}And it successfully commits.
I'm not actually sure if it breaks anything, as keepalived.conf might ignore the extra colon.
This is a much broader issue in fact, and has nothing to do with VRRP! It's also a possible shell injection, though for values coming from local sources it's irrelevant.
The issue is that the value wasn't quoted, see https://github.com/vyos/vyos-1x/blob/crux/src/helpers/validate-value.py#L31
Thus when the command was executed, it was like "${vyos_validators_dir}/numeric --range 1-255 50; and since it's run by system(), the semicolon was intepreted by the shell.
The correct way to run it would be "${vyos_validators_dir}/numeric --range 1-255 '50;' of course.
Oddly, I copied it to the OCaml version from current without noticing the implications! Fixed there: https://github.com/vyos/vyos-utils/commit/3f84c582f966f83d86cf066328eeced4704d63a4
Now I wonder if we should also fix it in Crux, or it's too risky and someone might have came to rely on it.
Accidentally committed a crux fix with https://github.com/vyos/vyos-1x/commit/920d87447ca479c311102260e5816ec0f5268a9b
Sorry about that.