Completion helper for "tcp" and "udp" is missing in command: set system syslog host 192.0.2.1 facility all protocol
- Difficulty level
- Normal (likely a few hours)
- Why the issue appeared?
- Will be filled on close
- Is it a breaking change?
- Unspecified (possibly destroys the router)
Nope, I was talking about completionHelper, which is not implemented - same as constraint nodes for udp/tcp regex.
There is a difference in valueHelp and completionHelp. valueHelp shows whats possible and completionHelp will conplete the CLI command once you hit TAB.
Gotcha, I start implement it for the rolling release for now. Since it affects multiple other nodes as well, I'll do it for all of them equally. aka facility has no constraint and completion help too. There are a few more I've found, so I crawl through all of them and enhance it a bit.
Wha cant the change which adds the completion helper be backported? Git best practice is you should group changes per commit. But in this commit you add the completion helper and also other regexes (BAD!)
You can via https://github.com/vyos/vyos-1x/commit/dad110ce666edae42ac18c59a800bda503589f27, which just sets the completion help.
For T1845, yes it solves the issue with setting address:port _and_ moves protocol up from facility to host. Do you want me to revert and do 2 commits, which requires then 2 migrations, once for address:port and one to solve the logical issue with protocol. Right now you can set a different protocol for different facilities for the same host.
@syncer https://github.com/vyos/vyos-1x/commit/dad110ce666edae42ac18c59a800bda503589f27 are only CLI modifications (validation to be be precise), no code changes at all which would change the functionality, in my opinion it can be backported as is.