Page MenuHomeVyOS Platform

Missing completion helper for "set system syslog host facility all protocol"
Closed, ResolvedPublicBUG


Completion helper for "tcp" and "udp" is missing in command: set system syslog host facility all protocol


Difficulty level
Normal (likely a few hours)
Why the issue appeared?
Will be filled on close
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

hagbard changed the task status from Open to On hold.Nov 27 2019, 11:09 PM

@c-po I used the 1.2.3 iso from the download portal and can't reproduce the issue. The help message was also already there since it was (re)implemented, could it be an issue with your installation?

Nope, I was talking about completionHelper, which is not implemented - same as constraint nodes for udp/tcp regex.

There is a difference in valueHelp and completionHelp. valueHelp shows whats possible and completionHelp will conplete the CLI command once you hit TAB.


hagbard changed the task status from On hold to In progress.EditedNov 28 2019, 4:16 PM

Gotcha, I start implement it for the rolling release for now. Since it affects multiple other nodes as well, I'll do it for all of them equally. aka facility has no constraint and completion help too. There are a few more I've found, so I crawl through all of them and enhance it a bit.

hagbard changed Difficulty level from Easy (less than an hour) to Normal (likely a few hours).Nov 28 2019, 4:30 PM

Thanks, should be backported to crux then as I found it there

hagbard changed the task status from Needs testing to Backport candidate.Nov 28 2019, 11:15 PM

Will interfere with T1845, while I think T1845 should be the backport candidate. Facility is a tag node, protocol has been moved on level up and is host specific. Having the availability to set different port per facility doesn't really make sense.

Wha cant the change which adds the completion helper be backported? Git best practice is you should group changes per commit. But in this commit you add the completion helper and also other regexes (BAD!)

You can via, which just sets the completion help.
For T1845, yes it solves the issue with setting address:port _and_ moves protocol up from facility to host. Do you want me to revert and do 2 commits, which requires then 2 migrations, once for address:port and one to solve the logical issue with protocol. Right now you can set a different protocol for different facilities for the same host.

@hagbard @c-po what we do with that? moving to 1.2.6?

@syncer are only CLI modifications (validation to be be precise), no code changes at all which would change the functionality, in my opinion it can be backported as is.

syncer changed the task status from Backport candidate to Backport pending.Apr 12 2020, 1:06 PM
syncer reassigned this task from hagbard to dmbaturin.
syncer moved this task from Backlog to In Progress on the VyOS 1.2 Crux (VyOS 1.2.5) board.
syncer added a subscriber: hagbard.