Page MenuHomeVyOS Platform
Create Task
Maniphest T1793

Editing description on an interface causes BGP sessions to reset on commit
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

When changing description on an interface (e.g. set interfaces ethernet eth9 vif 2510 description "something"), commit results in a reset of all BGP sessions. Don't see the reason why this is neccessary?

Details

Version
VyOS 1.2-rolling-201911100217
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Related Objects

Event Timeline

primoz created this task.Nov 10 2019, 12:05 AM
c-po subscribed.Nov 10 2019, 11:33 AM

There should be no reason the session is reset. This is an implementation "missdesign" by me when rewriting the ethernet interface. All interfaces are placed in admin down state on commit and will be placed in admin up state once the commit has run. and interface is not disabled.

This needs to be fixed. It also causes flapping switchports.

c-po changed the task status from Open to Confirmed.Nov 10 2019, 11:34 AM
c-po claimed this task.
c-po triaged this task as High priority.
c-po edited a custom field.
c-po added a comment.EditedNov 10 2019, 8:00 PM

The offender is the call to vyos.ifconfig.set_flow_control() which triggers /sbin/ethtool --pause eth0 autoneg on tx on rx on. we should only change this if it is really necessary and not on every commit.

c-po mentioned this in rVYOSONEXa1611eb01dd1: ifconfig: T1793: add delta check on set_flow_control().Nov 10 2019, 9:46 PM
c-po mentioned this in rVYOSONEX9e4947770064: ifconfig: T1793: add delta check on set_speed_duplex().
c-po added a comment.Nov 10 2019, 9:47 PM

Tomorrows rolling release will come with a first version of the fix. It requires you to use speed/duplex auto setting. The next part will also cover fixed speed/duplex settings.

c-po changed the task status from Confirmed to Needs testing.Nov 10 2019, 9:48 PM
c-po updated the task description. (Show Details)
c-po changed Version from - to VyOS 1.2-rolling-201911100217.
c-po moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.
pasik subscribed.Nov 11 2019, 5:53 PM
c-po mentioned this in rVYOSONEXc9c8cd50f416: ifconfig: T1793: extend set_speed_duplex() delta check.Nov 11 2019, 7:04 PM
c-po closed this task as Resolved.Nov 11 2019, 7:08 PM
c-po moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.
c-po mentioned this in rVYOSONEX80375d2be96c: Merge branch 'current' of github.com:vyos/vyos-1x into equuleus.Nov 11 2019, 7:14 PM
c-po mentioned this in rVYOSONEX242251ea50f1: ifconfig: T1793: remove dhcpv6 client debug output.Dec 6 2019, 6:33 PM
c-po mentioned this in rVYOSONEXbebd084651b5: Merge branch 'current' of github.com:vyos/vyos-1x into equuleus.Dec 6 2019, 8:08 PM
c-po added a comment.Jan 2 2020, 4:50 PM

As asked on slack and to be clear. This issue was never present in any of the 1.2 LTS releases (crux branch) - not in 1.2.0, 1.2.1, 1.2.2, 1.2.3 and 1.2.4.

Thus bug was only introduced in the current development branch and is fixed.

erkin set Issue type to Bug (incorrect behavior).Aug 31 2021, 6:20 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 30 2022, 2:06 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.