Page MenuHomeVyOS Platform
Create Task
Maniphest T1516

[wireguard] config changes cause an error
Closed, ResolvedPublicBUG
Actions

Description

When changing a wireguard config, it causes an error when the config items are being compared.

Traceback (most recent call last):

File "/usr/libexec/vyos/conf_mode/wireguard.py", line 370, in <module>
  apply(c)
File "/usr/libexec/vyos/conf_mode/wireguard.py", line 228, in apply
  addr_eff = re.sub("\'", "", c_eff.return_effective_values(intf + ' address')).split()
File "/usr/lib/python3.4/re.py", line 175, in sub
  return _compile(pattern, flags).sub(repl, string, count)

TypeError: expected string or buffer

interfaces wireguard wg01 failed
Commit failed

Details

Version
1.2, 1.3

Related Objects

Event Timeline

hagbard created this task.Jul 9 2019, 4:44 PM
hagbard claimed this task.
hagbard mentioned this in rVYOSONEX65b2f36a77f3: [wireguard] - T1516: changing committed config causes error.Jul 9 2019, 4:59 PM
hagbard closed this task as Unknown Status.Jul 9 2019, 5:00 PM

https://github.com/vyos/vyos-1x/commit/65b2f36a77f311a207b8e5406d222f4dbef177cf

hagbard triaged this task as Normal priority.Jul 9 2019, 5:00 PM
hagbard edited a custom field.
hagbard moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Jul 9 2019, 5:05 PM
c-po subscribed.Jul 10 2019, 3:31 PM

Issue present in the 1.2.2 ISO, too

hagbard added a comment.Jul 10 2019, 4:52 PM

this commit broke it: https://phabricator.vyos.net/rVYOSONEXd76798085ea8a77ffca3c6fbb6df74fc3121c333
There may be more scripts affected.

dmbaturin mentioned this in rVYOSONEX1725f958cf28: [wireguard] - T1516: changing committed config causes error.Jul 11 2019, 5:08 PM
hagbard changed the task status from Unknown Status to Resolved.Jul 15 2019, 2:30 PM
hagbard moved this task from Need Triage to Finished on the VyOS 1.2 Crux board.
syncer edited projects, added VyOS 1.2 Crux (VyOS 1.2.2); removed VyOS 1.2 Crux.Aug 31 2019, 2:50 AM
syncer moved this task from Needs Triage to Finished on the VyOS 1.2 Crux (VyOS 1.2.2) board.
dmbaturin removed a project: VyOS 1.3 Equuleus.Sep 10 2021, 2:16 PM