Page MenuHomeVyOS Platform
Create Task
Maniphest T1507

cli: logical redundancy with boolean type
Closed, ResolvedPublic
Actions

Description

I think exist another way that more simple to set param set system options reboot-on-panic true. Today I had some logical issue with this command

dimka@vyos-rtr1# set system options reboot-on-panic 
Possible completions:
   <boolean>    Reboot system on kernel panic

      
[edit]
dimka@vyos-rtr1# set system options reboot-on-panic 1

  "1" is not a valid value of type "bool"
  Value validation failed
  Set failed


[edit]
dimka@vyos-rtr1# set system options reboot-on-panic yes

  "yes" is not a valid value of type "bool"
  Value validation failed
  Set failed

[edit]
dimka@vyos-rtr1# set system options reboot-on-panic true

The fourth attempt was successful. I propose use only set system options reboot-on-panic without boolean types.

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)

Event Timeline

Unknown Object (User) created this task.Jul 5 2019, 11:53 AM
Unknown Object (User) triaged this task as Low priority.
Unknown Object (User) created this object in space S1 VyOS Public.
pasik subscribed.Jul 5 2019, 9:53 PM
syncer added a project: VyOS 1.3 Equuleus.Sep 24 2019, 2:31 AM
c-po subscribed.Sep 24 2019, 6:22 AM

Unfortunately we have multiple commands like this.

Viacheslav subscribed.Jul 24 2020, 3:31 PM

Fixed, VyOS 1.3-rolling-202007240117

vyos@r1-roll# set system options reboot-on-panic 
Possible completions:
  <Enter>	Execute the current command

Can we close it?

c-po added a comment.Jul 25 2020, 8:32 AM

Yes, I have migrated this a long time ago

c-po closed this task as Resolved.Jul 25 2020, 8:33 AM
c-po claimed this task.
c-po set Is it a breaking change? to Unspecified (possibly destroys the router).
c-po moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus board.Aug 3 2020, 3:26 PM
syncer edited projects, added VyOS 1.3 Equuleus (1.3.0); removed VyOS 1.3 Equuleus.Aug 29 2022, 7:13 PM
syncer moved this task from Need Triage to Finished on the VyOS 1.3 Equuleus (1.3.0) board.