I prefere set service syslog preserve-hostname as we use hostname in other configuration nodes, too

If you used set service syslog preserve-hostname, would you change the default rsyslog behavior to have $PreserveFQDN off?

set service syslog preserve-hostname would seem to mean "preserve the short-name" instead of FQDN or hostname.domain.name.

Maybe there are other better ways to ensure no ambiguity:

set service syslog use-domain-name
set service syslog use-full-hostname
set service syslog use-full-name
set service syslog include-domain-name

As a consultant in the DNS, DHCP and IPAM space, preserve-fqdn or use-fqdn makes a lot of sense to me as that's common lingo in my space.

just my 2 cents... Thanks

I rather would prefer only one option. The more options you have for things to configure - the more trouble you get.

As backwards compatibility is a must with VyOS we should leave it as it is and should not set $PreserveFQDN off as default. A new command should be added to only enable this feature. As the syslog daemon already calls it PreserveFQDN we should use that configuration node, too when thinking about it, twice.

set service syslog preserve-fqdn works for me.

What about:
set system syslog global preserve-fqdn

OOC why the term "global"? Do you foresee add'l global directives that you'd like added to that node or simply to keep things tidy under the syslog node?

Can you clarify please, I can't follow what you mean.

oh sorry, i was simply curious as to why you suggested adding the "global" node?

set service syslog preserve-fqdn
vs
set service syslog global preserve-fqdn

I suspect it's to prevent littering the service/syslog node itself...

this and it's a global rsyslog option only. (https://www.rsyslog.com/doc/v8-stable/configuration/global/index.html)

http://dev.packages.vyos.net/repositories/current/vyos/pool/main/v/vyos-1x/vyos-1x_1.3.0-11_all.deb or in tonights rolling, let me know if that works for you.

Tested using new rolling vyos-1.2.0-rolling+201903072319-amd64.iso

configure
set system syslog global preserve-fqdn
commit
save

searched these two files:

• /etc/rsyslog.conf
• /etc/rsyslog.d/vyos-rsyslog.conf

I noted the /etc/rsyslog.d/vyos-rsyslog.conf contains the $PreserveFQDN on option. Rsyslogd is restarted.

Graylog correctly contains FQDN source:

facility    security/authorization
level       6
message     vyos-lab-r01.ddiguru.net sshd[2367]: Received disconnect from 192.168.1.80: 11: disconnected by user
source      vyos-lab-r01.ddiguru.net
timestamp   2019-03-07 15:55:01.000 -07:00