Page MenuHomeVyOS Platform
Create Task
Maniphest T1183

BFD Support via FRR
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Since 1.2.0 has moved to FRR 6.1, which has native BFD support, can this be implemented in VyOS? Ideally this would be in the respective protocol config structures, such as 'procotols -> ospf -> bfd -> all interfaces'.

Details

Version
-

Related Objects

Event Timeline

trae32566 created this task.Jan 18 2019, 4:34 PM
syncer triaged this task as Normal priority.Jan 20 2019, 11:55 AM
syncer edited projects, added VyOS 1.3 Equuleus; removed VyOS 1.2 Crux.
pasik subscribed.Jan 21 2019, 9:43 PM
adestis subscribed.Feb 6 2019, 1:09 PM
rherold subscribed.Mar 17 2019, 2:22 PM
rherold added a comment.Mar 17 2019, 11:35 PM

Here is the current frr documentation:

http://docs.frrouting.org/en/latest/bfd.html

Seems that we must:

  1. enable bfdd in the frr dameons
  2. create protocols bfd for bfd configuration
  3. extend ospf ospf6 pim an bgpd to enable bfd
c-po merged a task: T1182: BFD Support via FRR.Jun 15 2019, 11:04 AM
c-po subscribed.

Also supported in EdgeOS

https://community.ubnt.com/t5/EdgeRouter/1-8-0-Documentation-Basic-Bidirectional-Forwarding-Detection-BFD/m-p/1339200#U1339200

c-po claimed this task.Jun 15 2019, 11:05 AM
c-po lowered the priority of this task from Normal to Low.
c-po edited a custom field.
c-po mentioned this in rVYOSONEXeaf2d83147e8: BFD: T1183: initial CLI implementation.Jun 16 2019, 6:24 PM
c-po mentioned this in rVYOSONEX3330017d1d34: BFD: T1183: IPv6 peers require explicit local address/interface.
c-po added subscribers: hagbard, dmbaturin.EditedJun 16 2019, 6:29 PM

A preliminary CLI interface has been created:

Anyone (@dmbaturin @hagbard) kows how to interact with FRR from a Python script?

FRR BFD manual http://docs.frrouting.org/en/latest/bfd.html

c-po added a comment.Jun 21 2019, 5:36 PM

What will be the desireded CLI syntax?

vyos@vyos# show protocols bfd
peer 1.2.3.4 {
    local-address 4.5.6.7
}
peer 2001:db8::1 {
    local-address 2001:db9:1::ffff
    local-interface eth0.201
}

or

vyos@vyos# show protocols bfd
peer 1.2.3.4 {
    local-address 4.5.6.7
}
peer 2001:db8::1 {
    source {
        address 2001:db9:1::ffff
        interface eth0.201
    }
}

or

vyos@vyos# show protocols bfd
peer 1.2.3.4 {
    local-address 4.5.6.7
}
peer 2001:db8::1 {
    source-address 2001:db9:1::ffff
    source-interface eth0.201
}

I vote for #2 as I like it the most (optically)

c-po mentioned this in rVYOSONEXecbe6c1c1b87: bfd: T1183: initial CLI implementation.Jun 23 2019, 10:20 AM
c-po mentioned this in rVYOSONEX4fa93aefd1e4: bfd: T1183: IPv6 peers require explicit local address/interface.
c-po mentioned this in rVYOSONEX1b1f6b20226c: bfd: T1183: add support for multihop.
c-po mentioned this in rVYOSONEX62ca0f555062: bfd: T1183: first working FRR bfd peer configuration.
c-po mentioned this in rVYOSONEXc2a8c1a22f43: bfd: T1183: adjust CLI syntax for source address/interface.
c-po mentioned this in rVYOSONEX4e4b945b6b88: bfd: T1183: add support to configure detection multiplier.
c-po mentioned this in rVYOSONEX67a35cfc37a5: bfd: T1183: multihop doesn't accept interface names.
c-po mentioned this in rVYOSONEX8b8c7424c902: bfd: T1183: add rx/tx interval configuration.
c-po mentioned this in rVYOSONEX921849da85c6: bfd: T1183: support show of individual BFD peer.
c-po mentioned this in rVYOSONEX745355d412ec: Merge branch 'bfd' into current.
c-po mentioned this in rVYOSONEX7d5b78242859: bfd: T1183: move "multiplier" configuration node to "interval multiplier".
c-po added a comment.Jun 23 2019, 10:26 AM

Next rolling will come with preliminary FRR BFD (FRR BFD manual http://docs.frrouting.org/en/latest/bfd.html) support.

Please note: the CLI design is not yet final and might change as this is still experimental!

OSPF

set interface ethernet eth0 ip ospf bfd

BGP

set protocols bgp AS neighbor IP bfd
set protocols bgp AS peer-group NAME bfd

BFD

set protocols bfd peer IP multihop
set protocols bfd peer IP shutdown
set protocols bfd peer IP multihop
set protocols bfd peer IP interval receive
set protocols bfd peer IP interval transmit
set protocols bfd peer IP interval multiplier
set protocols bfd peer IP source address
set protocols bfd peer IP source interface

show protocols bfd peer
show protocols bfd peer IP

c-po moved this task from Need Triage to In Progress on the VyOS 1.3 Equuleus board.Jun 23 2019, 5:53 PM
c-po changed the task status from Open to Needs testing.Jun 25 2019, 5:06 PM
shaneshort subscribed.EditedJul 5 2019, 7:52 AM

Just a comment: wouldn't have these configuration options be inferred from the peer they're on?

IE.. why do I need to configure a BGP peer for BFD, then enable specific BFD options in a separate section? Wouldn't it make more sense to put it under the bgp peer? for example:

protocols {
	bgp 31337 {
		neighbor 1.2.3.4 {
			update-source lo0;
			bfd {
				interval receive 100ms;
				source 1.2.3.3;
				multihop;
			}
		}
	}
}

I imagine you could do the same for OSPF/Static as required

rherold added a comment.Jul 5 2019, 8:02 AM

For my point of view this is a dependency from the bfd protocol specs.

You are only allowed to have one bfd connection to one bfd peer via same interface. See RFC.

This means if you configure bfd via bgp and then you need it on the same target in ospf or any other protocol you will run into a hell of
configuration dependency checking... Or if you delete one of the protocols.

rodge.liu subscribed.Jul 29 2019, 4:02 AM
zsdc subscribed.Aug 9 2019, 3:55 PM

I have added two PRs with some fixes and new features. The most valuable changes:

  • Fixed the bug, which prevents to change or delete BFD peers with custom options. For example, when any of source address/interface, multihop was used, such peers could not be deleted or changed.
  • Added configuration checks, which should prevent adding BFD option to BGP neighbors or peer-groups without corresponding peers configuration in protocols bfd. If BGP and BFD configurations are out of sync, BGP sessions could be very unstable.
  • Added configuration check, which should prevent to delete peers from protocols bfd if they are still used in BGP.
  • Some other small fixes and changes.

Also, was added several new options:
BFD configuration:

set protocols bfd peer IP echo-mode
set protocols bfd peer IP interval echo-interval

BGP configuration:

set protocols bgp ASN neighbor IP bfd check-control-plane-failure
Unknown Object (User) subscribed.Aug 10 2019, 8:11 PM
Restricted Repository Identity mentioned this in rVYOSONEX02408b253845: Merge pull request #99 from zdc/feature-bfd.Aug 12 2019, 7:24 PM
Unknown Object (User) added a comment.Aug 13 2019, 9:58 PM

We also can add show protocols bfd peer counters and for peer show protocols bfd peer x.x.x.x counters

vyos@vyos-rtr01# run show protocols bfd peer counters | strip-private 
BFD Peers:
	peer xxx.xxx.0.4 local-address xxx.xxx.0.1 vrf default
		Control packet input: 0 packets
		Control packet output: 988 packets
		Echo packet input: 0 packets
		Echo packet output: 0 packets
		Session up events: 0
		Session down events: 0
		Zebra notifications: 0

	peer xxx.xxx.0.2 local-address xxx.xxx.0.1 vrf default
		Control packet input: 0 packets
		Control packet output: 983 packets
		Echo packet input: 0 packets
		Echo packet output: 0 packets
		Session up events: 0
		Session down events: 0
		Zebra notifications: 0

PR https://github.com/vyos/vyos-1x/pull/104

Restricted Repository Identity mentioned this in rVYOSONEX8d1e768a6f32: Merge pull request #104 from DmitriyEshenko/bfd.Aug 14 2019, 10:37 AM
Restricted Repository Identity mentioned this in rVYOSONEX652cb0bb710f: Merge pull request #105 from zdc/T1183.Aug 17 2019, 12:17 AM
trae32566 added a comment.Sep 21 2019, 6:47 PM

Just some feedback here, but this has been working flawlessly in all my environments so far for BGP, OSPF, and OSPFv3 ... you guys are awesome!

adestis added a comment.Sep 25 2019, 7:30 AM

It would be awsome if the feature could also be made available in the next VyOS 1.2.x version.
Because it likely takes a lot more time until version 1.3 gets released.

trae32566 added a comment.Sep 25 2019, 2:06 PM

This feature is currently in the 1.2 rolling release.

adestis added a comment.Oct 4 2019, 6:46 AM

Hi trae32566

you are using the rolling release also for production?
Have you seen any issues with BFD so far?

Regards
Markus

trae32566 added a comment.Oct 6 2019, 10:23 PM

Yes I'm currently utilizing the rolling releases in service after basic functionality testing, and so far BFD has worked flawlessly for all protocols I've tested.

syncer closed this task as Unknown Status.Oct 7 2019, 5:52 AM
syncer raised the priority of this task from Low to Normal.
syncer added a project: VyOS 1.2 Crux (VyOS 1.2.4).
syncer moved this task from In Progress to Finished on the VyOS 1.3 Equuleus board.
syncer moved this task from Needs Triage to Backlog on the VyOS 1.2 Crux (VyOS 1.2.4) board.
c-po added a comment.Oct 7 2019, 6:22 AM

I would not backport it. Its a proof of concept and things are still unclear about peer configuration (why does cumulus FRR behave differently and has no peer config) also the FRR interface is only a PoC.

Its also against the LTS term definition. Its not a bugfix - its a feature enhancement.

Anyone has some VyOS <-> Juniper or VyOS <-> Cisco working configs for the docs?

trae32566 added a comment.Oct 7 2019, 6:34 AM

I have a VyOS <-> Arista configuration, which should be similar to Cisco, if that works for y'all?

c-po added a comment.Oct 7 2019, 6:54 AM

@trae32566 definately! As Arista is gaining more food in the marked please share it here so we can then add it to our documentation.

adestis added a comment.Oct 9 2019, 7:16 AM

@c-po wrote:
I would not backport it. Its a proof of concept and things are still unclear about peer configuration (why does cumulus FRR behave differently and has no peer config) also the FRR interface is only a PoC.

BFD is an essential feature for service providers. The task list of the 1.2.x is still very long.
That means that we would get version 1.3 somewhere next year.
This really would be a problem!

So, please do a backport of this feature.

Thank you
Markus

rherold added a comment.Oct 9 2019, 8:06 AM

@cpo cumulus behave differently cause they use an other implementation as in pure frr. They use PTMD see https://docs.cumulusnetworks.com/cumulus-linux/Layer-3/Bidirectional-Forwarding-Detection-BFD/ and https://github.com/CumulusNetworks/ptm

also +1 for an backport

trae32566 added a comment.EditedOct 10 2019, 5:04 AM

I made a test lab at home for this, so let me know if you have any other settings or anything you need documentation for.

Configs

Arista EOS

EOS 4.20 done in a VRF to segregate:

ir01(config-s-BFD_TE)#show session-config diff | i ^\+
+++ session:/BFD_TEST-session-config
+!
+vlan 250
+   name BFD-TEST
+!
+!
+vrf definition BFD-TEST
+   description VyOS and Arista BFD testing
+!
+interface Vlan250
+   description VyOS and Arista BFD testing
+   vrf forwarding BFD-TEST
+   ip address 192.0.2.1/30
+   ipv6 enable
+   ipv6 address 2001:db8::192:0:2:1/64
+   ipv6 address fe80::192:0:2:1/64 link-local
+   ip ospf bfd
+   ip ospf area 0.0.0.0
+   ipv6 ospf bfd
+   ipv6 ospf 2 area 0.0.0.0
+ip routing vrf BFD-TEST
+ipv6 unicast-routing vrf BFD-TEST
+ipv6 router ospf 2 vrf BFD-TEST
+   passive-interface default
+   no passive-interface Vlan250
+!
+router ospf 2 vrf BFD-TEST
+   passive-interface default
+   no passive-interface Vlan250
+   network 192.0.2.0/30 area 0.0.0.0
+   max-lsa 12000
+!

VyOS

VyOS 1.2-rolling-201910061306 diff from a virgin install:

vyos@vyos# compare saved
[edit interfaces]
+bonding bond0 {
+    address 192.0.2.2/30
+    address 2001:db8::192:0:2:2/64
+    description "VyOS and Arista BFD testing"
+    hash-policy layer3+4
+    ip {                                                                                                        
+        ospf {                                                                                                  
+            bfd                                                                                                 
+        }
+    }
+    ipv6 {                                                                                                        
+        ospfv3 {                                                                                                  
+            bfd                                                                                                 
+        }
+    }
+    member {
+        interface eth0
+        interface eth1
+    }
+    mode xor-hash
+}
[edit]
+protocols {
+    bfd {
+        peer 192.0.2.1 {
+            source {
+                interface bond0
+            }
+        }
+        peer fe80::192:0:2:1 {
+            source {
+                address fe80::5054:ff:fee5:79a4
+                interface bond0
+            }
+        }
+    }
+    ospf {
+        area 0.0.0.0 {
+            network 192.0.2.0/30
+        }
+        passive-interface default
+        passive-interface-exclude bond0
+    }
+    ospfv3 {
+        area 0.0.0.0 {
+            interface bond0
+        }
+    }
+}
[edit]

Output

Arista EOS

ir01#show bfd neighbors vrf BFD-TEST 
VRF name: BFD-TEST
-----------------
DstAddr                MyDisc         YourDisc        Interface         Type               LastUp       LastDown            LastDiag    State 
--------------- ---------------- ---------------- ---------------- ------------ -------------------- -------------- ------------------- ----- 
192.0.2.2          3357120480       2203358781       Vlan250(2)       normal       10/09/19 23:19             NA       No Diagnostic       Up 

DstAddr                              MyDisc        YourDisc        Interface         Type               LastUp       LastDown            LastDiag    State 
----------------------------- ---------------- --------------- ---------------- ------------ -------------------- -------------- ------------------- ----- 
fe80::5054:ff:fee5:79a4          3802158902       931194054       Vlan250(2)       normal       10/09/19 23:19             NA       No Diagnostic       Up 

ir01#show bfd neighbors vrf BFD-TEST detail 
VRF name: BFD-TEST
-----------------
Peer Addr 192.0.2.2, Intf Vlan250, Type normal, State Up
VRF BFD-TEST, LAddr 192.0.2.1, LD/RD 3357120480/2203358781
Session state is Up and not using echo function
Last Up Oct 09 23:19:24 2019
Last Down NA
Last Diag: No Diagnostic
TxInt: 300, RxInt: 300, Multiplier: 3
Received RxInt: 300, Received Multiplier: 3
Rx Count: 4684, Rx Interval (ms) min/max/avg: 224/300/263 last: 473 ms ago
Tx Count: 4767, Tx Interval (ms) min/max/avg: 192/300/258 last: 473 ms ago
Detect Time: 900
Sched Delay: 1*TxInt: 6576, 2*TxInt: 3, 3*TxInt: 0, GT 3*TxInt: 0
Registered protocols: ospf
Uptime: 20:31.90
Last packet:  Version: 1            - Diagnostic: 0           
              State bit: Up         - Demand bit: 0           
              Poll bit: 0           - Final bit: 0            
              Multiplier: 3         - Length: 24              
              My Discr.: 2203358781 - Your Discr.: 3357120480 
              Min tx interval: 300  - Min rx interval: 300    
              Min Echo interval: 50                           

Peer Addr fe80::5054:ff:fee5:79a4, Intf Vlan250, Type normal, State Up
VRF BFD-TEST, LAddr fe80::192:0:2:1, LD/RD 3802158902/931194054
Session state is Up and not using echo function
Last Up Oct 09 23:19:24 2019
Last Down NA
Last Diag: No Diagnostic
TxInt: 300, RxInt: 300, Multiplier: 3
Received RxInt: 300, Received Multiplier: 3
Rx Count: 4694, Rx Interval (ms) min/max/avg: 224/300/262 last: 478 ms ago
Tx Count: 4763, Tx Interval (ms) min/max/avg: 215/300/258 last: 478 ms ago
Detect Time: 900
Sched Delay: 1*TxInt: 6579, 2*TxInt: 1, 3*TxInt: 0, GT 3*TxInt: 0
Registered protocols: ospfv3_ipv6
Uptime: 20:31.50
Last packet:  Version: 1            - Diagnostic: 0           
              State bit: Up         - Demand bit: 0           
              Poll bit: 0           - Final bit: 0            
              Multiplier: 3         - Length: 24              
              My Discr.: 931194054  - Your Discr.: 3802158902 
              Min tx interval: 300  - Min rx interval: 300    
              Min Echo interval: 50

VyOS

vyos@vyos:~$ show protocols bfd peer
BFD Peers:
        peer fe80::192:0:2:1 local-address fe80::5054:ff:fee5:79a4 vrf default interface bond0
                ID: 931194054
                Remote ID: 3802158902
                Status: up
                Uptime: 17 minute(s), 42 second(s)
                Diagnostics: ok
                Remote diagnostics: ok
                Local timers:
                        Receive interval: 300ms
                        Transmission interval: 300ms
                        Echo transmission interval: 50ms
                Remote timers:
                        Receive interval: 300ms
                        Transmission interval: 300ms
                        Echo transmission interval: 300ms

        peer 192.0.2.1 vrf default interface bond0
                ID: 2203358781
                Remote ID: 3357120480
                Status: up
                Uptime: 17 minute(s), 42 second(s)
                Diagnostics: ok
                Remote diagnostics: ok
                Local timers:
                        Receive interval: 300ms
                        Transmission interval: 300ms
                        Echo transmission interval: 50ms
                Remote timers:
                        Receive interval: 300ms
                        Transmission interval: 300ms
                        Echo transmission interval: 300ms


vyos@vyos:~$ show protocols bfd peer counters
BFD Peers:
        peer fe80::192:0:2:1 local-address fe80::5054:ff:fee5:79a4 vrf default interface bond0
                Control packet input: 4164 packets
                Control packet output: 4100 packets
                Echo packet input: 0 packets
                Echo packet output: 0 packets
                Session up events: 1
                Session down events: 0
                Zebra notifications: 1

        peer 192.0.2.1 vrf default interface bond0
                Control packet input: 4166 packets
                Control packet output: 4090 packets
                Echo packet input: 0 packets
                Echo packet output: 0 packets
                Session up events: 1
                Session down events: 0
                Zebra notifications: 1
harris7139 subscribed.Oct 22 2019, 2:02 PM
c-po added a comment.Oct 27 2019, 3:47 AM
This comment was removed by c-po.
syncer reassigned this task from c-po to dmbaturin.Nov 16 2019, 11:54 PM
dmbaturin changed the task status from Unknown Status to Resolved.Nov 17 2019, 6:48 PM
trae32566 added a comment.Nov 17 2019, 6:54 PM

Just a note, I updated my docs above cause they were missing the OSPF+OSPFv3 portion of the interface config that enabled BFD :)

syncer moved this task from Backlog to Finished on the VyOS 1.2 Crux (VyOS 1.2.4) board.Jan 1 2020, 1:04 PM
dmbaturin removed a project: VyOS 1.3 Equuleus.Sep 10 2021, 2:28 PM
c-po mentioned this in rVYOSONEXb6598b7f9f8c: bfd: T1183: use unified error style.Dec 6 2021, 7:01 PM