HomeVyOS Platform

rm_templates: T8609: fix set_comm_list_delete parser regression
f40f74631e56Unpublished

Unpublished Commit ยท Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

rm_templates: T8609: fix set_comm_list_delete parser regression

CodeRabbit caught that the original T8609 fix in this branch made
set_comm_list_delete's (?P<delete>\S+) group required. The
parser's setval emits set comm-list delete with no token after
delete, so the parser stopped matching its own output. Pre-T8609
the trailing * quantifier on the group made it accidentally
optional after VERBOSE strip; tightening that to \s*$ removed the
optionality.

Replace delete(?P<delete>\S+)\s*$ with \s(?P<delete>delete)\s*$
in route_maps.py and route_maps_14.py. The named group now captures
the literal word delete; the result template
"{{True if delete is defined}}" continues to evaluate True when
the group matches.

Adds a round-trip regression test asserting the parser matches its
own setval-generated line. No existing fixture covered this case,
which is why the original commit shipped the regression.

Also adds a perf budget test for Bgp_address_familyTemplate14, the
one template family the original commit's perf coverage missed.

Details

Provenance
cr0ntabAuthored on May 1 2026, 5:25 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.