HomeVyOS Platform
Diffusion VyOS Ansible Collection db2f799287c3

rm_templates: T8609: route_maps.py: address PR #470 review feedback
db2f799287c3Unpublished
Actions

Unpublished Commit ยท Learn More

  • Publishing Disabled: All publishing is disabled for this repository.
  • Not On Permanent Ref: This commit is not an ancestor of any permanent ref.
This commit no longer exists in the repository. It may have been part of a branch which was deleted.This commit has been deleted in the repository: it is no longer reachable from any branch, tag, or ref.

Description

rm_templates: T8609: route_maps.py: address PR #470 review feedback

Two findings on route_maps.py from CodeRabbit review of PR #470.

  • Five trailing-form patterns in parsers sequence, on_match_next, set_atomic_aggregate, set_extcommunity_bandwidth_non_transitive, and match_community_exact_match still had the (?P<name>...)\n *$ shape that collapses to (?P<name>...)*$ under re.VERBOSE. Collapsed each to \s*$ on the same line as the named group, matching the rest of the PR.
  • The set_comm_list_delete parser captures (?P<delete>delete) (boolean token) and writes to set.comm_list.delete in result, but compval read set.comm_list.comm_list (the string sibling field defined in argspec/route_maps/route_maps.py:64). Changed compval to set.comm_list.delete so it lines up with the parser's capture and result path.

Details

Provenance
cr0ntabAuthored on May 21 2026, 9:11 PM

Event Timeline

Commit No Longer Exists

This commit no longer exists in the repository.