T2295: vyos_user: set explicit no_log on update_password (#479)
- vyos_user: set no_log=False on update_password parameter
Prevents Ansible from redacting update_password in module args when
configured_password is present with no_log=True.
Co-authored-by: Cursor <cursoragent@cursor.com>
- T2295: document why update_password needs explicit no_log=False
Ansible PASSWORD_MATCH hides parameters named *password* when no_log is
unset (not the same as defaulting to False). Add comment, changelog
wording, and a unit test; align with ansible.core user module.
Co-authored-by: Cursor <cursoragent@cursor.com>
- T2295: add comment for update_password no_log=False
Co-authored-by: Cursor <cursoragent@cursor.com>
- T2295: drop source-inspection test for update_password no_log
Remove test_vyos_user_update_password_explicit_no_log_false; existing
execute_module tests already cover update_password behavior.
Co-authored-by: Cursor <cursoragent@cursor.com>
- T2295: fix CI failures (changelog line length, devel/py3.12 matrix)
Shorten the changelog fragment to satisfy ansible-lint line-length (160).
Skip py3.12-devel tox environments and exclude devel+Python 3.12 from
unit-source now that ansible-core devel requires Python >=3.13.
Co-authored-by: Cursor <cursoragent@cursor.com>
- Add docstrings to vyos_user functions and workflow permissions
Adds docstrings to all undocumented module-level functions in
vyos_user.py to bring docstring coverage above the 80% threshold.
Adds explicit permissions: contents: read to codecoverage.yml
as recommended by CodeRabbit for least-privilege CI security.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Revert "Add docstrings to vyos_user functions and workflow permissions"
This reverts commit 616b27bc339a7607eae15e91a605c70dae15248b.
- T2295: drop unrelated CI/tox changes; reword changelog
Revert the matrix_exclude block in tests.yml and the py3.12-devel skip in
tox-ansible.ini; those were CI workarounds unrelated to this fix and are no
longer needed against current main. Reword the changelog fragment to describe
the observable behavior instead of the internal PASSWORD_MATCH constant.
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: omnom62 <75066712+omnom62@users.noreply.github.com>
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>