Change Details

Viacheslav Hletenko Is it possible to say darker do not check quotes format? https://github.com/vyos/vyos-1x/actions/runs/15839019126/job/44648182916?pr=4574#step:7:29 John Estabrook My understanding is that Black, hence Darker, insists on double quotes; one can skip the check all together with --skip-string-normalization, but not set preference to single quotes: https://github.com/psf/black/issues/118#issuecomment-393298377 https://github.com/psf/black/issues/373#issuecomment-580238240 (edited) Taras Pudiak The problem seems to be that ruff doesn't use our ruff.toml configuration file because there we've changed style to a single quotes. I'm recalling that probably that was the reason why that second one (now removed) improper ruff check was introduced as a temporary solution.

Viacheslav Hletenko Is it possible to say darker do not check quotes format? https://github.com/vyos/vyos-1x/actions/runs/15839019126/job/44648182916?pr=4574#step:7:29 John Estabrook My understanding is that Black, hence Darker, insists on double quotes; one can skip the check all together with --skip-string-normalization, but not set preference to single quotes: https://github.com/psf/black/issues/118#issuecomment-393298377 https://github.com/psf/black/issues/373#issuecomment-580238240 Taras Pudiak The problem seems to be that ruff doesn't use our ruff.toml configuration file because there we've changed style to a single quotes. I'm recalling that probably that was the reason why that second one (now removed) improper ruff check was introduced as a temporary solution.

Viacheslav Hletenko Is it possible to say darker do not check quotes format? https://github.com/vyos/vyos-1x/actions/runs/15839019126/job/44648182916?pr=4574#step:7:29 John Estabrook My understanding is that Black, hence Darker, insists on double quotes; one can skip the check all together with --skip-string-normalization, but not set preference to single quotes: https://github.com/psf/black/issues/118#issuecomment-393298377 https://github.com/psf/black/issues/373#issuecomment-580238240 (edited) Taras Pudiak The problem seems to be that ruff doesn't use our ruff.toml configuration file because there we've changed style to a single quotes. I'm recalling that probably that was the reason why that second one (now removed) improper ruff check was introduced as a temporary solution.