Being worked

Duplicate of existing PR

Duplicate of T6892

Raised a Draft PR https://github.com/vyos/vyos.vyos/pull/368

Fixed for 1.3+ along with test verifications

I was looking into this again today. As I mentioned in the pull request, there is an issue with the draft PR. What happens is that the current config is retrieved using the command show configuration commands instead of show configuration. The output does not contain any less specific config paths, as they would be useless in configuring a system. However, when determining what to delete, this information is essential.

The fix is now a part of https://github.com/vyos/vyos.vyos/pull/367

the PR to fix this is https://github.com/vyos/vyos.vyos/pull/367

The PR tp fix this https://github.com/vyos/vyos.vyos/pull/367

Implemented for the next 1.4.1
@a.apostoliuk recheck please and close if works as expected

The PR# is re-submitted for review and testing

Path issues and unit tests resolved

Raised https://github.com/vyos/vyos.vyos/pull/365

Per slack, this is being investigated for re-introduction into 1.4.1. Putting this on pause for now.

It appears that path-limit GBP network options is deprecated

@Viacheslav @dmbaturin need to be fixed in 1.4.1

Confirmed this is happening with current mainline and 1.4, but not 1.2,1.3 or 1.5.

Maybe it will be fixed after merging https://vyos.dev/T6045

I did some investigation - apparently the plugin cannot match the full command pattern (including optional attributes) and silently refuses to generate a resultant set of commands - I will be looking into this - most likely the issue is related to rm_templates regex patterns for getval

Per slack conversation.

This should be fixed by

@sdwilsh Are you good to close this out? The change in ipv6 should be handled by the updated version now in main

@rob, we may need a bit of help with this from you

I was looking for this too, and actually started to play with the code of the module to get this feature in a few weeks ago. I've submitted my changes as a draft PR on Github. I've been playing with managing my VyOS config from SCM for my home lab. It's important when I for example remove a firewall rule, it is also deleted in the running config, instead of being orphaned. It seems to work pretty well in my setup, but I am uncertain if nothing breaks in other workflows.

Ready for review.

I've got a fix for this in the works.

I'm back home now, feel free to send them to me and I'll take a look at it today (I have a few minutes now, but likely will need to look at it in about 12 hours).

Update - I cloned the current vyo.vyos changes, created a branch and made the changes that Maxime proposed.

sure, ok - I will do needful for it to be tests ready
It does not appear a huge change to me

Maybe ask the author to resubmit against the current?

I believe it was forked a while ago (in March this year) and never refreshed after that - so the fork (and PK) is using older version of the repo

was that after rebasing it onto our current main branch or applying changes directly? Or something else?

Sanity tests are failing pretty much all:
FATAL: The 5 sanity test(s) listed below (out of 34) failed. See error output above for details.
action-plugin-docs
import --python 3.12
pep8
pylint
validate-modules

Yeah, changes are pretty small and also pretty isolated. I’m guessing the merge might be fast, unless there are significant conflicts. However if there are conflicts probably faster to re-apply the change.

Or I may just re-introduce the changes into the working current branch given they are all straight forward

Started to look into this - but it seems to be based on older version of collection (57 commits behind) and failing all the sanity checks.
I will try and refresh that branch and re-test

On it, @syncer

Let’s get tests at least for the changes here before we check it in. It should be trivial to test, especially since it looks like there is no version difference to take into account.

@evgmol can you please review the pull request provided, if ok we should merge it

I raised a draft PR (https://github.com/vyos/vyos.vyos/pull/357) to tackle some of the compatibility issues. I will try and finalise it in coming days