Page MenuHomeVyOS Platform

wan-load-balancing: empty firewall-group warning is never shown
Open, Requires assessmentPublic

Description

src/conf_mode/load-balancing_wan.py calls Warning(f'{error_group} "{group_name}" has no members!') for a rule that uses an existing but empty firewall group, but does not import vyos.base.Warning. The call creates Python's builtin Warning exception and discards it, so the warning is never printed.

Import vyos.base.Warning as the firewall, NAT and policy-route scripts do.

Details

Version
rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)