Page MenuHomeVyOS Platform

firewall: port-multi validator accepts words from /etc/services comments as service names
Open, Requires assessmentPublic

Description

The port-multi validator (used for firewall and NAT ports) reads /etc/services and adds every field after the port as an alias. Debian's file has trailing comments, e.g. ssh 22/tcp # SSH Remote Login Protocol, so #, SSH, Remote, Login, Protocol, TCP, multiplexer and so on are accepted as service names: set firewall ipv4 forward filter rule 10 destination port Remote passes validation.

Strip comments before splitting each line.

Details

Version
rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)