Page MenuHomeVyOS Platform

vyos-build: least-privilege GITHUB_TOKEN permissions for the trigger workflows
Open, NormalPublic

Description

The vyos-build trigger workflows run with more GITHUB_TOKEN permissions than they need:

  • .github/workflows/trigger_rebuild_packages.yml (push to rolling) has no permissions: block, so it gets the repository default token permissions, unlike the other workflows in the repo.
  • .github/workflows/trigger-docker-image-build.yml (pull_request_target, closed) grants packages: write, attestations: write and id-token: write, but the job only checks out the repo, runs dorny/paths-filter and calls the dispatch API with a PAT. The write scopes date from the first version of the file (T6771).

Fix: contents: read for the package trigger; contents: read + pull-requests: read (needed by paths-filter on PR events) for the Docker trigger.

Details

Version
rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Internal change (not visible to end users)