Page MenuHomeVyOS Platform

vyos-build: image build continues when a build command is killed by a signal
Open, NormalPublic

Description

The image build helpers treat a process killed by a signal as success. scripts/image-build/utils.py (cmd(), rc_cmd()) and scripts/image-build/raw_image.py (loop device setup) check returncode > 0, but Python reports a process terminated by a signal with a negative return code (e.g. -9 for SIGKILL). An OOM-killed lb build or qemu-img step therefore lets build-vyos-image continue with an incomplete image instead of failing.

Also, the missing-dependencies error printed the packages and binaries lines run together (E: Missing packages: aE: Missing binaries: b).

Fix: check != 0 in all three places and add the missing newline.

Details

Version
rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)