Page MenuHomeVyOS Platform

vyos-build: rebuild trigger workflows report success when the dispatch call fails
Open, NormalPublic

Description

The vyos-build trigger workflows call the GitHub workflow_dispatch API with curl -L and no --fail:

  • .github/workflows/trigger_rebuild_packages.yml (trigger_build())
  • .github/workflows/trigger-docker-image-build.yml

If the PAT expires or loses scope, or the remote workflow is renamed, the API answers 401/404/422 but curl exits 0, so the job is green and the package or builder image is silently not rebuilt.

Also, the pam_tacplus path filter and trigger in trigger_rebuild_packages.yml are dead: scripts/package-build/pam_tacplus was removed when it was folded into tacacs (ef9e1f84).

Fix: use curl --fail-with-body --retry 3; in the package workflow keep triggering the remaining packages and fail the job at the end if any trigger failed. Remove the pam_tacplus filter and trigger.

Details

Version
rolling
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)