Page MenuHomeVyOS Platform

protocols_rpki: all /run/frr/id_rpki* keys deleted before writing only the current VRF's keys
In progress, HighPublicBUG

Description

RPKI SSH key files are globbed and deleted for every VRF before only the current VRF's keys are rewritten, and the file names are not VRF-qualified.

Location
protocols_rpki.py:82-83, :93-94

python/vyos/frrender.py:469-470, :660-661

Problem
Glob-unlink runs before VRF selection; key file names are not VRF-qualified.

Impact
Default-VRF RPKI SSH caches lose their keys when a VRF instance commits; same cache name in two VRFs collides.

Suggested fix
Qualify file names with the VRF and delete only that VRF's stale keys.

Details

Version
rolling
Is it a breaking change?
Perfectly compatible
Issue type
Bug (incorrect behavior)

Event Timeline

natali-rs1985 changed the task status from Open to In progress.
natali-rs1985 claimed this task.
natali-rs1985 triaged this task as High priority.
natali-rs1985 updated the task description. (Show Details)