Page MenuHomeVyOS Platform

Kernel: Intel out-of-tree NIC drivers ignore commit_id pins from package.toml
Closed, ResolvedPublicBUG

Description

build.py checks out each Intel driver at the commit_id set in scripts/package-build/linux-kernel/package.toml. build-intel-nic.sh then runs git reset --hard origin/main, which throws that checkout away. As a result, every Intel driver (igb, ixgbe, ixgbevf, i40e, iavf, ice) is built from whatever is on Intel's main at build time instead of the pinned release.

Builds can't be reproduced, and the pins have no effect.

Observed on circinus branch (after 1.5.1 release, before 1.5.2):

DriverPinnedIn image
ixgbev6.4.56.5.9
ixgbevfv5.2.25.3.87
i40ev2.28.162.30.83
iavfv4.13.204.13.78
icev2.6.72.7.6

Fix: reset to HEAD (the pinned commit) instead of origin/main. Needs a backport to Circinus.

Note: driver versions may go down compared with the current images unless the pins are bumped, which happens in this task, too to keep the current state but make it reproducible.

Details

Version
rolling, 1.5.1, 1.4.6
Is it a breaking change?
Perfectly compatible
Issue type
Infrastructure issue or change