Summary
Interfaces migration script 27-to-28 (T4995) renames the CLI node
authentication user to authentication username for PPPoE, SSTP client
and WWAN interfaces. The interface type list contains a typo: wwam
instead of wwan. interfaces wwam never exists, so WWAN interfaces are
silently skipped and keep the old user node.
for type in ['pppoe', 'sstpc-client', 'wwam']:
Steps to reproduce
- Start from a configuration at interfaces version < 28 with:
set interfaces wwan wwan0 apn 'internet' set interfaces wwan wwan0 authentication user 'foo' set interfaces wwan wwan0 authentication password 'bar'
- Upgrade to an image that ships interfaces migration 27-to-28.
Expected behavior
authentication user is renamed to authentication username, as it is
for PPPoE and SSTP client interfaces.
Actual behavior
The user node is left untouched under interfaces wwan. It is no longer
part of the CLI definition, so the migrated config holds an invalid path
and the WWAN credentials are lost.
Notes
- Found by code review, not reproduced on hardware.
- Fixing the typo only helps configs that have not been migrated past version 28 yet. Systems that already ran the broken migration would need a new interfaces migration step to rename the leftover node.