Page MenuHomeVyOS Platform

smoketest: bgp: shorten test_protocols_bgp runtime by dropping a fixed sleep and redundant commits
Closed, ResolvedPublicFEATURE REQUEST

Description

Most of the time in the BGP smoketest goes to config commits, at about 0.7 s each on a lab DUT. On top of that, test_bgp_99_bmp had a fixed 10 second sleep after killing bgpd so it would restart with the BMP module.

The sleep is now replaced by polling "show watchfrr". The test continues once bgpd has a new PID, watchfrr reports it as Up and Idle, and it has finished reading its configuration.

This is also more reliable than before: a fixed delay could pick up a PID that watchfrr then replaced. The timeout of 90 seconds follows the watchfrr restart timeout.

Details

Version
rolling-20261017
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Revisions and Commits

Event Timeline

c-po changed the task status from Open to In progress.
c-po triaged this task as Low priority.
Restricted Repository Identity closed this task as Resolved by committing Restricted Diffusion Commit.Mon, Oct 19, 4:26 PM
Restricted Repository Identity added a commit: Restricted Diffusion Commit.