There is a logical flaw in the set vpp settings allow-unsupported-nics configuration option.
Steps to reproduce:
- Use a NIC that is not on our whitelist.
- Enable the allow-unsupported-nics option and add the NIC to VPP.
- The commit will succeed, and the NIC will be attached (assuming it does not crash the dataplane).
- Remove the allow-unsupported-nics configuration option and commit the changes.
- At this point, the NIC remains attached to VPP despite the option no longer being present in the configuration. The CLI does not flag this inconsistency as an error - this is the first issue.
- If this configuration is saved and the system is rebooted, the entire VPP configuration section becomes invalid and fails to load during boot - this is the more critical consequence.