Page MenuHomeVyOS Platform

policy-route: cleanup nested XML include structure
Closed, ResolvedPublicFEATURE REQUEST

Description

interface-definitions/policy_route.xml.in includes the same XML definitions more then ocne.

Example:

<node name="source">
  <properties>
    <help>Source parameters</help>
  </properties>
  <children>
    #include <include/firewall/address-ipv6.xml.i>
    #include <include/firewall/source-destination-group-ipv6.xml.i>
    #include <include/firewall/port.xml.i>
    #include <include/firewall/geoip.xml.i>
  </children>
</node>
#include <include/policy/route-common.xml.i>
#include <include/policy/route-ipv6.xml.i>

The contents of #include <include/policy/route-ipv6.xml.i> are a re-include of:

  • #include <include/firewall/address-ipv6.xml.i>
  • #include <include/firewall/source-destination-group-ipv6.xml.i>
  • #include <include/firewall/port.xml.i>

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Event Timeline

c-po claimed this task.
c-po updated the task description. (Show Details)
c-po moved this task from Need Triage to Completed on the VyOS Rolling board.
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Feature (new functionality) to Internal change (not visible to end users).