Page MenuHomeVyOS Platform

"Monitor protocols" commands broken
Open, Requires assessmentPublicBUG

Description

Many of the FRR related debug commands within monitor protocols are broken due to incorrect parsing logic.

Commands with nested options like this fail to capture the full debug path:

monitor protocol bgp enable vnc verbose
monitor protocol ospf enable lsa install
....and more

This seems to be due to this command parsing used throughout the op-mode template:

<node name="install">
 <command>vtysh -c "no debug ospf ${@:5}"</command>
</node>

The command should probably be this instead, which parses everything after ospf as a string instead of a list of args:

vtysh -c "no debug ospf ${*:5}"

Details

Version
1.5
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Bug (incorrect behavior)

Event Timeline

I like the idea. Maybe we can extend this logic to other things, like WireGuard or VPNs. @a.apostoliuk @dmbaturin