Page MenuHomeVyOS Platform

consolidate container run arguments
Open, LowPublic

Description

Currently the generate_run_arguments in container.py has to two different exit points depending on the network used

if 'allow_host_networks' in container_config:
    return f'{container_base_cmd} {healthcheck} --net host {entrypoint} {image} {command} {command_arguments}'.strip()

...
return f'{container_base_cmd} {healthcheck} --net {networks} {ip_param} {mac_address} {entrypoint} {image} {command} {command_arguments}'.strip()

This already led to --no-healthchecks only being added to one and not the other => use one place holder for network to generate the run arguments once

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Unspecified (please specify)