Page MenuHomeVyOS Platform

Consolidate container run arguments
Closed, ResolvedPublic

Description

Currently the generate_run_arguments in container.py has to two different exit points depending on the network used

if 'allow_host_networks' in container_config:
    return f'{container_base_cmd} {healthcheck} --net host {entrypoint} {image} {command} {command_arguments}'.strip()

...
return f'{container_base_cmd} {healthcheck} --net {networks} {ip_param} {mac_address} {entrypoint} {image} {command} {command_arguments}'.strip()

This already led to --no-healthchecks only being added to one and not the other => use one place holder for network to generate the run arguments once

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Event Timeline

Viacheslav moved this task from Need Triage to Completed on the VyOS Rolling board.
dmbaturin renamed this task from consolidate container run arguments to Consolidate container run arguments.Feb 12 2026, 6:03 PM
dmbaturin changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
dmbaturin changed Issue type from Unspecified (please specify) to Internal change (not visible to end users).