Page MenuHomeVyOS Platform
Create Task
Maniphest T7564

Change behavior of ruff linter in pull requests
Closed, ResolvedPublicFEATURE REQUEST
Actions

Description

Currently we do run the ruff linter for the entire files part of a PR which could, will and does drive contributors crazy.
It also mixes formatting changes with fixes to the code base.

The global RUFF linter should be disabled and maybe become a PR review by a bot.

In addition we already have the "darker ruff" workflow which will/should only complaint about the actual diff inside a PR and not the entire file.
https://github.com/vyos/.github/blob/current/.github/workflows/lint-with-darker-ruff.yml

Details

Version
-
Is it a breaking change?
Perfectly compatible
Issue type
Internal change (not visible to end users)

Related Objects

Event Timeline

c-po created this task.Jun 19 2025, 2:57 PM
c-po changed the task status from Open to In progress.
c-po claimed this task.
c-po triaged this task as Normal priority.
c-po updated the task description. (Show Details)
c-po changed Is it a breaking change? from Unspecified (possibly destroys the router) to Perfectly compatible.
c-po changed Issue type from Feature (new functionality) to Internal change (not visible to end users).
c-po mentioned this in rVYOSONEX4534d7f9327c: T7564: GitHub: remove ruff linter PR check - should be an automated review.Jun 19 2025, 2:59 PM
Restricted Repository Identity mentioned this in rVYOSONEXbf7d9897f14a: Merge pull request #4560 from c-po/ruff-lint.Jun 19 2025, 2:59 PM
c-po moved this task from Need Triage to Completed on the VyOS Rolling board.Jun 19 2025, 3:00 PM
Restricted Repository Identity mentioned this in rVYOSONEX32b8bfce41cc: T7564: added darker ruff lint workflow.Jun 19 2025, 3:23 PM
Restricted Repository Identity mentioned this in rVYOSONEXbdb5846987fa: Merge pull request #4567 from kumvijaya/current.Jun 19 2025, 3:23 PM
c-po closed this task as Resolved.Jun 19 2025, 3:23 PM
pasik subscribed.Jun 19 2025, 5:48 PM