Page MenuHomeVyOS Platform

Build package binaries script should exit if a package repository cannot be cloned for some reason
In progress, NormalPublicFEATURE REQUEST

Description

Summary
The build-package binaries script has to exit with a non-zero code if a package repository cannot be cloned for some reason

Use case

All repositories defined in the package.toml MUST be processed (clone/build/patch/etc)
Otherwise, we have an issue when not all kernel modules were signed, like in this example

in the repo

kernel  03-Jun-2025 15:37  
accel   30-May-2025 18:11

build skipped accel-ppp repo, but build other

Cleaned up build dependency packages
Copied generated .deb packages
Failed to build package accel-ppp: Command '['git', 'clone', 'https://github.com/accel-ppp/accel-ppp.git', 'accel-ppp']' returned non-zero exit status 128.
Copied generated .deb packages
I: Tarball created: ovpn-dco-v0.2.20231117.tar.gz
Cleaned up build dependency packages
Copied generated .deb packages
Cleaned up build dependency packages
Copied generated .deb packages
Copied generated .deb packages
Copied generated .deb packages

This way, kernel modules and accel modules are signed by different keys, and ipoe/vlan_mon cannot be loaded.

accel-ppp-modules.png (365×1 px, 130 KB)

small summary

[[packages]]
name = "fake-repo"
commit_id = "v0.0.1"
scm_url = "https://github.com/vyos/fake-repo"

[[packages]]
name = "ethtool"
commit_id = "debian/1%6.10-1"
scm_url = "https://salsa.debian.org/kernel-team/ethtool"

If ethtool depends on some fake-package and this package cannot be downloaded from the repo, then we shouldn't build the ethtool package at all.

Details

Version
-
Is it a breaking change?
Unspecified (possibly destroys the router)
Issue type
Feature (new functionality)